assert: remove deprecated getFunction() usage

BridgeAR · targos · commit a38de61e87dc · 2023-03-13T11:23:16.000+01:00
The method is meant to be removed by the V8 team. It is not a critical functionality that is removed, therefore no alternative is checked for either. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #46661 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/assert.js b/lib/assert.js
@@ -308,12 +308,7 @@ function getErrMessage(message, fn) {
       return;
     }
   } else {
-    const fn = call.getFunction();
-    if (!fn) {
-      return message;
-    }
-    code = String(fn);
-    identifier = `${code}${line}${column}`;
+    return message;
   }
 
   if (errorCache.has(identifier)) {
diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -921,7 +921,7 @@ assert.throws(
   {
     code: 'ERR_ASSERTION',
     constructor: assert.AssertionError,
-    message: 'The expression evaluated to a falsy value:\n\n  assert(1 === 2)\n'
+    message: 'false == true'
   }
 );
 assert.throws(

Original file line number	Diff line number	Diff line change
`@@ -308,12 +308,7 @@ function getErrMessage(message, fn) {`
`308`	`308`	`return;`
`309`	`309`	`}`
`310`	`310`	`} else {`
`311`		`- const fn = call.getFunction();`
`312`		`- if (!fn) {`
`313`		`- return message;`
`314`		`- }`
`315`		`- code = String(fn);`
`316`		- identifier = `${code}${line}${column}`;
	`311`	`+ return message;`
`317`	`312`	`}`
`318`	`313`
`319`	`314`	`if (errorCache.has(identifier)) {`
Original file line number	Diff line number	Diff line change
`@@ -921,7 +921,7 @@ assert.throws(`
`921`	`921`	`{`
`922`	`922`	`code: 'ERR_ASSERTION',`
`923`	`923`	`constructor: assert.AssertionError,`
`924`		`- message: 'The expression evaluated to a falsy value:\n\n assert(1 === 2)\n'`
	`924`	`+ message: 'false == true'`
`925`	`925`	`}`
`926`	`926`	`);`
`927`	`927`	`assert.throws(`