Skip to content

Commit b39fb9a

Browse files
StefanStojanovicRafaelGSS
authored andcommitted
win: fix SIGQUIT on ClangCL
PR-URL: #57659 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent da281d7 commit b39fb9a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/node.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@
6767
#endif
6868

6969
#ifdef _WIN32
70-
# define SIGKILL 9
70+
#define SIGQUIT 3
71+
#define SIGKILL 9
7172
#endif
7273

7374
#include "v8.h" // NOLINT(build/include_order)

test/parallel/test-child-process-kill.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ assert.strictEqual(cat.killed, true);
4242

4343
// Test different types of kill signals on Windows.
4444
if (common.isWindows) {
45-
// SIGQUIT is not supported on Windows 2022, Visual Studio 2022 ClangCL-produced node.exe.
46-
// TODO(StefanStojanovic): Investigate this and re-enable it when the issue is fixed.
47-
for (const sendSignal of ['SIGTERM', 'SIGKILL', /* 'SIGQUIT', */'SIGINT']) {
45+
for (const sendSignal of ['SIGTERM', 'SIGKILL', 'SIGQUIT', 'SIGINT']) {
4846
const process = spawn('cmd');
4947
process.on('exit', (code, signal) => {
5048
assert.strictEqual(code, null);

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy