Only allow supported dtypes in the array_api namespace asarray()

numpy · charris · Aug 24, 2021 · Jan 11, 2021 · Jan 11, 2021 · Jan 11, 2021
commit a42f71ac8ac559d0ef770bdfd2f62bd1be4848d5
diff --git a/numpy/_array_api/_creation_functions.py b/numpy/_array_api/_creation_functions.py
@@ -11,13 +11,18 @@ def asarray(obj: Union[float, NestedSequence[bool|int|float], SupportsDLPack, Su
 
     See its docstring for more information.
     """
+    from ._array_object import ndarray
+    from . import _dtypes
     if device is not None:
         # Note: Device support is not yet implemented on ndarray
         raise NotImplementedError("Device support is not yet implemented")
     if copy is not None:
         # Note: copy is not yet implemented in np.asarray
         raise NotImplementedError("The copy keyword argument to asarray is not yet implemented")
-    return np.asarray(obj, dtype=dtype)
+    res = np.asarray(obj, dtype=dtype)
+    if res.dtype not in _dtypes._all_dtypes:
+        raise TypeError(f"The array_api namespace does not support the dtype {res.dtype}")
+    return ndarray._new(res)
 
 def arange(start: Union[int, float], /, *, stop: Optional[Union[int, float]] = None, step: Union[int, float] = 1, dtype: Optional[dtype] = None, device: Optional[device] = None) -> array:
     """

diff --git a/numpy/_array_api/_dtypes.py b/numpy/_array_api/_dtypes.py
@@ -1,3 +1,6 @@
 from .. import int8, int16, int32, int64, uint8, uint16, uint32, uint64, float32, float64
 # Note: This name is changed
 from .. import bool_ as bool
+
+_all_dtypes = [int8, int16, int32, int64, uint8, uint16, uint32, uint64,
+               float32, float64, bool]