Skip to content

MAINT: Use python shim and clean up CI script calls #29324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MAINT: Use python shim and clean up CI script calls #29324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
- run:
name: build NumPy
command: |
python3.11 -m venv venv
python -m venv venv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to leave this as is. We secifically must build the dicumentation with python 3.11 since we have distutils extensions. I wouldn’t want the version to change out from under us without it causing an obvious error

. venv/bin/activate
pip install --progress-bar=off -r requirements/test_requirements.txt \
-r requirements/build_requirements.txt \
Expand All @@ -69,7 +69,7 @@ jobs:
# Don't use -q, show warning summary"
SPHINXOPTS="-W -n" spin docs
if [[ $(find doc/build/html -type f | wc -l) -lt 1000 ]]; then
echo "doc build failed: doc/build/html is empty"
echo "doc build failed: doc/build/html is empty" >&2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong with the way this is? Why force stderr?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful if the logs are being streamed to any observability tool where it is possible to monitor it easily based on stdout or stderr stream. Happy to remove it if it seems unnecessary.

exit -1
fi

Expand Down Expand Up @@ -97,8 +97,8 @@ jobs:
# - validates ReST blocks (via validate_rst_syntax)
# - checks that all of a module's `__all__` is reflected in the
# module-level docstring autosummary
echo calling python3 tools/refguide_check.py -v
python3 tools/refguide_check.py -v
echo "calling ./tools/refguide_check.py -v"
./tools/refguide_check.py -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anything, I would prefer this specifically uses python 3.11 like above

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They all are symlinked to same python binary anyway configured in cimg/python:3.11.10 image. Thought it migth be cleaner to stick to just one common invocation format. Like how we are invoking pip and not pip3 or pip3.11. Unless I'm missing some obvious side effects.


- persist_to_workspace:
root: ~/repo
Expand Down
Empty file modified tools/refguide_check.py
100644 → 100755
View file
Open in desktop
Empty file.
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy