Skip to content

TST: refactor typing check for @ #29364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2025
Merged

TST: refactor typing check for @ #29364

merged 3 commits into from
Jul 13, 2025
+3 −7

Conversation

deniederhut
Copy link
Contributor

Previously, there was a separate file for a python 3 typing check for @. This commit removes the extra file and consolidates the typing checks in simple.py

Somewhat related to #22635

@deniederhut
TST: refactor typing check for @
9ba3287 
Previously, there was a separate file for a python 3 typing
check for `@`. This commit removes the extra file and
consolidates the typing checks in `simple.py`

Somewhat related to numpy#22635
@jorenham jorenham self-requested a review July 12, 2025 19:39
jorenham
jorenham reviewed Jul 12, 2025
View reviewed changes
Copy link
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a couple of nits, this seems like a good change to me. Thanks :)

deniederhut and others added 2 commits July 12, 2025 14:50
@deniederhut @jorenham
Update numpy/typing/tests/data/pass/simple.py
6699853 
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
@deniederhut @jorenham
Update numpy/typing/tests/data/pass/simple.py
4e57dda 
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
jorenham
jorenham approved these changes Jul 12, 2025
View reviewed changes
Copy link
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge if CI passes

@deniederhut
Copy link
Contributor Author

Not sure what happened here. Does github actions have a "rerun only failed workflows" button?

@deniederhut
Copy link
Contributor Author

For what it's worth I can't reproduce this locally

________________________________________________ test_array_scalar_ufunc_equivalence ________________________________________________

>   ???
E   hypothesis.errors.DidNotReproduce: Expected the test to raise an error, but it completed successfully.

f          = <function given.<locals>.run_test_as_given.<locals>.wrapped_test at 0x106403d80>

numpy/_core/tests/test_scalarmath.py:121: DidNotReproduce
------------------------------------------------------------ Hypothesis -------------------------------------------------------------
Falsifying example: test_array_scalar_ufunc_equivalence(
    op=mul,
    arr1=array(3.+1.j, dtype=complex64),
    arr2=array(3.5287092e+07+1.j, dtype=complex64),
)
====================================================== short test summary info ======================================================
FAILED numpy/_core/tests/test_scalarmath.py::test_array_scalar_ufunc_equivalence - hypothesis.errors.DidNotReproduce: Expected the test to raise an error, but it completed successfully.

@jorenham jorenham merged commit 031377b into numpy:main Jul 13, 2025
90 of 91 checks passed
@jorenham
Copy link
Member

Thanks @deniederhut!

@deniederhut
Copy link
Contributor Author

🙇

@deniederhut deniederhut deleted the tst/py2_refactor branch July 14, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham jorenham approved these changes

Assignees
No one assigned
Labels
05 - Testing 41 - Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deniederhut @jorenham
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy