BUG: Fix repeatability issues in test suite #29380
Merged
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves test failures caused by persistent global state
when running numpy.test() twice in the same Python session.
- core/tests: Skip TestAddNewdocUfunc on repeated runs.
This avoids C-level mutation errors.
- f2py/tests: Reset f77modulename at end of callcrackfortran.
This change alters the code base.
- lib/tests: Wrap StringIO parameters in lambdas.
- f2py/tests/test_docs: Reset ftype.data.a at end of test_ftype.
These changes ensure that the full test suite can be run multiple
times in the same interpreter without failure. Closes numpy#26718.
ngoldbaum
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
This all seems harmless enough, let's bring it in. Thanks @bmwoodruff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves test failures caused by persistent global state when running numpy.test() twice in the same Python session.
These changes ensure that the full test suite can be run multiple times in the same interpreter without failure. Closes #26718.
The change to
f2py/testscause a change in the behavior ofcallcrackfortran. I'd like feedback. I believe the change here solves the root problem of the failing tests. An alternative is to just patch over the issue in the test suite alone usingsetup_module()+reset_global_f2py_vars().A more detailed description of each change is located at #26718 (comment).
@ngoldbaum , this should finish up the issue from the sprints at SciPy.