ENH: Testing utils show max errors for 0-dim numeric object arrays #29399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test passes again This minor omission wasn't visible due to the blanket TypeError suppression which was only meant for non-numeric types. This could also handle other edge-cases in which the error is numeric but non-subscriptable.
ngoldbaum
reviewed
Jul 21, 2025
| 'Max absolute difference among violations: ' | ||
| '455428622900749238826454011358190875\n' | ||
| 'Max relative difference among violations: ' | ||
| '24.571119015281806\n') |
There was a problem hiding this comment.
The tortured grammar around plurals here sort of make me want to special-case this message for scalars. Is that painful to do here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this very minor omission while working on #29395
It wasn't visible due to the blanket
TypeErrorsuppression which was only meant for non-numeric types.This could also handle other edge-cases in which the error is numeric but non-subscriptable.