Skip to content

fix(nuxt): wrap slot with h() in ClientOnly #30664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2025
Merged

fix(nuxt): wrap slot with h() in ClientOnly #30664

merged 2 commits into from
Jan 20, 2025

Conversation

huang-julien
Copy link
Member

🔗 Linked issue

fix #30638
fix #30243

📚 Description

Hye 👋

We forgot to wrap the slot with h() in ClientOnly

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2025 •
edited
Loading

Walkthrough

The pull request introduces modifications to the ClientOnly component in the Nuxt framework, specifically within the packages/nuxt/src/app/components/client-only.ts file. The main change involves updating the setup function by renaming its parameter from an underscore (_) to props, allowing for direct access to the component's props. Additionally, the return statement of the setup function has been simplified to return a function without parameters, enabling direct access to slots and attrs. The handling of the fallback slot has also been refined, now wrapping the slot output in a h() function call to ensure it is treated as a VNode. These changes enhance the clarity of the code and refine the rendering logic without altering the overall functionality or structure of the component.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ae59d1 and 0d334f2.

📒 Files selected for processing (1)
  • packages/nuxt/src/app/components/client-only.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/nuxt/src/app/components/client-only.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 19, 2025 •
edited
Loading

Open in Stackblitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@30664

nuxt

npm i https://pkg.pr.new/nuxt@30664

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@30664

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@30664

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@30664

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@30664

commit: 0d334f2

@huang-julien huang-julien marked this pull request as draft January 19, 2025 15:51
@huang-julien huang-julien marked this pull request as ready for review January 19, 2025 16:09
@danielroe danielroe merged commit c5a78ea into main Jan 20, 2025
45 checks passed
@danielroe danielroe deleted the fix/clientonly_fallback branch January 20, 2025 06:47
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
Draft
Kamsou pushed a commit to Kamsou/nuxt that referenced this pull request Feb 5, 2025
@huang-julien @Kamsou
fix(nuxt): wrap slot with h() in ClientOnly (nuxt#30664)
09cfb9a
danielroe pushed a commit that referenced this pull request May 31, 2025
@huang-julien @danielroe
fix(nuxt): wrap slot with h() in ClientOnly (#30664)
4e8c8c2
@github-actions github-actions bot mentioned this pull request May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@danielroe danielroe Awaiting requested review from danielroe danielroe is a code owner

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClientOnly issue with fallback Component in ClientOnly with fallback ignores undefined attributes
3 participants
@huang-julien @antfu @danielroe
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy