Skip to content

refactor: replace useServerHead in onPrehydrate with useHead #31585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

refactor: replace useServerHead in onPrehydrate with useHead #31585

merged 1 commit into from
Mar 31, 2025

Conversation

Mini-ghost
Copy link
Member

🔗 Linked issue

📚 Description

The useServerHead composable has been deprecated. According to the unhead documentation, it is recommended to use useHead instead and wrap it with if (import.meta.server).

@Mini-ghost Mini-ghost requested a review from danielroe as a code owner March 30, 2025 13:31
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 30, 2025 •
edited
Loading

Walkthrough:

The changes involve updating a server-side rendering component by renaming the imported function from useServerHead to useHead. This modification is reflected in two places: the import statement at the beginning of the file and the invocation of the function within the onPrehydrate function. Additionally, the signature of the useRequestEvent function has been altered to make the nuxtApp parameter optional. A new conditional check has been introduced to allow early returns when the code is executed on the client side. The handling of the nuxtApp variable has been adjusted to employ the nullish coalescing assignment operator (||=) for default assignment. The overall control flow and error handling mechanisms within the onPrehydrate function remain unchanged, with no alterations to the parameters passed to useHead.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5bdbc02 and c575308.

📒 Files selected for processing (1)
  • packages/nuxt/src/app/composables/ssr.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/nuxt/src/app/composables/ssr.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build
  • GitHub Check: code
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 30, 2025 •
edited
Loading

Open in Stackblitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@31585

nuxt

npm i https://pkg.pr.new/nuxt@31585

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@31585

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@31585

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@31585

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@31585

commit: 5bdbc02

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 30, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #31585 will not alter performance

Comparing Mini-ghost:refactor/on-prehydrate (5bdbc02) with main (2a1e192)

Summary

✅ 10 untouched benchmarks

@Mini-ghost Mini-ghost force-pushed the refactor/on-prehydrate branch from c575308 to 5bdbc02 Compare March 30, 2025 13:58
@danielroe danielroe merged commit ceff6a0 into nuxt:main Mar 31, 2025
87 checks passed
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Draft
danielroe pushed a commit that referenced this pull request Mar 31, 2025
@Mini-ghost @danielroe
refactor: replace useServerHead in onPrehydrate with useHead (#…
0e6daac 
…31585)
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Merged
@Mini-ghost Mini-ghost deleted the refactor/on-prehydrate branch March 31, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mini-ghost @danielroe
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy