Skip to content

fix(nuxt): pass slots through to lazy hydrated components #31649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

fix(nuxt): pass slots through to lazy hydrated components #31649

merged 1 commit into from
Apr 2, 2025

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #31633

📚 Description

we weren't passing slots through; this fixes the issue.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 2, 2025

Walkthrough

The change updates the setup function within the lazy component definition so that the slots from the context are passed to the rendered component. Previously, the function called h with the component, merged attributes, and an onVnodeMounted handler. The new implementation now includes the context's slots as an additional argument to the h function. No modifications were made to the declarations of exported or public entities.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b9b7dc and 1b25720.

📒 Files selected for processing (1)
  • packages/nuxt/src/components/runtime/lazy-hydrated-component.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build
  • GitHub Check: code
🔇 Additional comments (1)
packages/nuxt/src/components/runtime/lazy-hydrated-component.ts (1)

25-25: Good fix! This resolves the slot passing issue.

This change enables slots to be correctly passed through to the lazy hydrated component by adding ctx.slots as the third parameter to the h function. Without this, slots would be lost during the component's lazy rendering process, preventing users from adding custom content within these components.

The implementation is clean and follows Vue's rendering conventions where the h function accepts the component, props, and children/slots as parameters.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 2, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@31649

nuxt

npm i https://pkg.pr.new/nuxt@31649

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@31649

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@31649

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@31649

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@31649

commit: 1b25720

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 2, 2025

CodSpeed Performance Report

Merging #31649 will not alter performance

Comparing fix/lazy-hydrated-slots (1b25720) with main (7570ede)

Summary

✅ 10 untouched benchmarks

@danielroe danielroe merged commit 1218bba into main Apr 2, 2025
83 of 84 checks passed
@danielroe danielroe deleted the fix/lazy-hydrated-slots branch April 2, 2025 17:24
@github-actions github-actions bot mentioned this pull request Apr 2, 2025
Draft
danielroe added a commit that referenced this pull request Apr 4, 2025
@danielroe
fix(nuxt): pass slots through to lazy hydrated components (#31649)
5e1dae8
@github-actions github-actions bot mentioned this pull request Apr 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lazy hydration ignores slot content in components
1 participant
@danielroe
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy