Skip to content

fix(nuxt): don't redirect when route has trailing slash #31902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2025
Merged

fix(nuxt): don't redirect when route has trailing slash #31902

merged 5 commits into from
Apr 28, 2025

Conversation

kyohei-23
Copy link
Contributor

🔗 Linked issue

resolves #31521

📚 Description

The idea with #22192 was likely to make URLs the same with or without a trailing slash, but it didn't.
This is due to using isEqual with trailingSlash:true option.

As I mentioned in my comment on the issue, there are two ways to tackle this problem, but I figured using isSamePath, with its simpler arguments and clearer usage, would be better.

@kyohei-23 kyohei-23 requested a review from danielroe as a code owner April 25, 2025 16:18
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 25, 2025 •
edited
Loading

Walkthrough

The changes include an update in the Nuxt runtime router plugin, where the path comparison utility was switched from isEqual to isSamePath, and the corresponding logic in the createCurrentLocation function was updated to use the new utility. This alters the method by which path equality is determined within the router logic. Additionally, a test case in the bundle size tests was modified to expect a total client bundle size of "171k" instead of "172k". No exported or public entity declarations were changed in either update.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 539b0d5 and db1ebee.

📒 Files selected for processing (1)
  • test/bundle.test.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • test/bundle.test.ts
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 25, 2025 •
edited
Loading

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@31902

nuxt

npm i https://pkg.pr.new/nuxt@31902

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@31902

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@31902

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@31902

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@31902

commit: db1ebee

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #31902 will not alter performance

Comparing kyohei-23:fix/remove-trailing-slash-on-page-load (db1ebee) with main (96734ce)

Summary

✅ 10 untouched benchmarks

danielroe
danielroe reviewed Apr 26, 2025
View reviewed changes
@danielroe danielroe merged commit 6977bb3 into nuxt:main Apr 28, 2025
44 of 46 checks passed
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Draft
danielroe pushed a commit that referenced this pull request Apr 28, 2025
@kyohei-23 @danielroe
fix(nuxt): don't redirect when route has trailing slash (#31902)
c498a16
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Merged
@kyohei-23 kyohei-23 deleted the fix/remove-trailing-slash-on-page-load branch May 10, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SSG] The trailing "/" is missing from the browser address bar link
2 participants
@kyohei-23 @danielroe
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy