Skip to content

fix(nuxt): provide nuxtApp for server handler #32038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

fix(nuxt): provide nuxtApp for server handler #32038

merged 1 commit into from
May 8, 2025

Conversation

xjccc
Copy link
Contributor

@xjccc xjccc commented May 8, 2025

🔗 Linked issue

📚 Description

Is it need to provide nuxtApp for server _handler?

Thank you❤

@xjccc xjccc requested a review from danielroe as a code owner May 8, 2025 10:05
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 8, 2025

Walkthrough

The change updates the way a cached promise is created in the createAsyncData function during prerendering with a shared prerender cache. Instead of passing the handler function directly to nuxtApp.runWithContext, the code now wraps the handler in an arrow function that explicitly calls _handler with nuxtApp as an argument. This ensures that _handler receives nuxtApp directly during prerender cache retrieval. No changes were made to the declarations or signatures of exported or public entities.

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28661df and 9547400.

📒 Files selected for processing (1)
  • packages/nuxt/src/app/composables/asyncData.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build
  • GitHub Check: codeql (javascript-typescript)
  • GitHub Check: code
🔇 Additional comments (1)
packages/nuxt/src/app/composables/asyncData.ts (1)

610-610: Enhancement: Now providing nuxtApp to handler when using prerender cache

The change ensures that the server handler function (_handler) receives access to the Nuxt application context by explicitly passing nuxtApp as an argument when executing within runWithContext. This is important for server handlers that need access to the Nuxt application's features, plugins, or configuration.

Previously, the handler might not have had consistent access to the nuxtApp context when executed from the prerender cache.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 8, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32038

nuxt

npm i https://pkg.pr.new/nuxt@32038

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32038

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32038

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32038

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32038

commit: 9547400

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 8, 2025

CodSpeed Performance Report

Merging #32038 will not alter performance

Comparing xjccc:fix/async-data-server-handler (9547400) with main (28661df)

Summary

✅ 10 untouched benchmarks

@danielroe danielroe merged commit dc7ef15 into nuxt:main May 8, 2025
47 checks passed
@github-actions github-actions bot mentioned this pull request May 8, 2025
Draft
danielroe pushed a commit that referenced this pull request May 8, 2025
@xjccc @danielroe
fix(nuxt): provide nuxtApp for asyncData functions run on server (#…
c516774 
…32038)
@github-actions github-actions bot mentioned this pull request May 8, 2025
Merged
@xjccc xjccc deleted the fix/async-data-server-handler branch May 9, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xjccc @danielroe
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy