fix(nuxt): support reactive keys in `useLazyAsyncData` #32092

danielroe · 2025-05-13T10:52:41Z

🔗 Linked issue

resolves #32091

📚 Description

when implementing support for reactive keys in #31373 we didn't update the check for a valid key in useLazyAsyncData. This syncs it with useAsyncData.

bolt-new-by-stackblitz · 2025-05-13T10:52:44Z

Run & review this pull request in StackBlitz Codeflow.

Copilot

Pull Request Overview

Syncs the valid key check in useLazyAsyncData with useAsyncData to support reactive keys and function-overload signatures.

Expanded the conditional to recognize object keys and handler-only signatures.
Updated argument unshifting to align with useAsyncData’s behavior.

Copilot · 2025-05-13T10:53:28Z

packages/nuxt/src/app/composables/asyncData.ts

@@ -472,7 +472,7 @@ export function useLazyAsyncData<
  DefaultT = undefined,
 > (...args: any[]): AsyncData<PickFrom<DataT, PickKeys>, (NuxtErrorDataT extends Error | NuxtError ? NuxtErrorDataT : NuxtError<NuxtErrorDataT>) | undefined> {
  const autoKey = typeof args[args.length - 1] === 'string' ? args.pop() : undefined
-  if (typeof args[0] !== 'string') { args.unshift(autoKey) }
+  if (typeof args[0] !== 'string' && typeof args[0] !== 'object' && !(typeof args[0] === 'function' && typeof args[1] === 'function')) { args.unshift(autoKey) }


The condition typeof args[0] !== 'object' will treat null (where typeof null === 'object') as a valid key, which may lead to unintended behavior. Consider explicitly checking for args[0] != null before accepting object keys.

Suggested change

if (typeof args[0] !== 'string' && typeof args[0] !== 'object' && !(typeof args[0] === 'function' && typeof args[1] === 'function')) { args.unshift(autoKey) }

if (args[0] != null && typeof args[0] !== 'string' && typeof args[0] !== 'object' && !(typeof args[0] === 'function' && typeof args[1] === 'function')) { args.unshift(autoKey) }

Copilot · 2025-05-13T10:53:28Z

packages/nuxt/src/app/composables/asyncData.ts

@@ -472,7 +472,7 @@ export function useLazyAsyncData<
  DefaultT = undefined,
 > (...args: any[]): AsyncData<PickFrom<DataT, PickKeys>, (NuxtErrorDataT extends Error | NuxtError ? NuxtErrorDataT : NuxtError<NuxtErrorDataT>) | undefined> {
  const autoKey = typeof args[args.length - 1] === 'string' ? args.pop() : undefined
-  if (typeof args[0] !== 'string') { args.unshift(autoKey) }
+  if (typeof args[0] !== 'string' && typeof args[0] !== 'object' && !(typeof args[0] === 'function' && typeof args[1] === 'function')) { args.unshift(autoKey) }


[nitpick] The combined type-check condition is quite dense and may hinder readability. Consider extracting each predicate into clearly named boolean variables (e.g., isStringKey, isReactiveKey, isHandlerOnlySignature) or a helper function to improve clarity.

Suggested change

if (typeof args[0] !== 'string' && typeof args[0] !== 'object' && !(typeof args[0] === 'function' && typeof args[1] === 'function')) { args.unshift(autoKey) }

const isStringKey = typeof args[0] === 'string'

const isReactiveKey = typeof args[0] === 'object'

const isHandlerOnlySignature = typeof args[0] === 'function' && typeof args[1] === 'function'

if (!isStringKey && !isReactiveKey && !isHandlerOnlySignature) {

args.unshift(autoKey)

}

coderabbitai · 2025-05-13T10:54:43Z

Walkthrough

The update refactors the logic that determines whether to prepend an automatically extracted key (autoKey) to the argument list in the useAsyncData and useLazyAsyncData functions. It replaces the previous inline condition with a new helper function _isAutoKeyNeeded that centralises the checks. This helper returns false if the first argument is a string, a non-null object (including refs or computed values), or a function followed by another function; otherwise, it returns true. The change is internal and does not affect the public interface or exported declarations.

Tip

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c9d05b and d073d7f.

📒 Files selected for processing (1)

packages/nuxt/src/app/composables/asyncData.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/nuxt/src/app/composables/asyncData.ts

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: build
GitHub Check: code

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-05-13T10:56:39Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32092

nuxt

npm i https://pkg.pr.new/nuxt@32092

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32092

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32092

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32092

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32092

commit: d073d7f

codspeed-hq · 2025-05-13T11:06:12Z

CodSpeed Performance Report

Merging #32092 will not alter performance

_{Comparing fix/lazy-reactive (d073d7f) with main (76b300e)}

Summary

✅ 10 untouched benchmarks

fix(nuxt): support reactive keys in useLazyAsyncData

5c9d05b

Copilot AI review requested due to automatic review settings May 13, 2025 10:52

github-actions bot added 3.x bug labels May 13, 2025

Copilot AI reviewed May 13, 2025

View reviewed changes

refactor: extract into shared function that's easier to read

d073d7f

danielroe merged commit 0b55bf7 into main May 13, 2025
82 of 83 checks passed

danielroe deleted the fix/lazy-reactive branch May 13, 2025 20:39

This was referenced May 13, 2025

v4.0.0 #27716

Draft

support reactive keys in useLazyAsyncData nuxt/bridge#1526

Open

danielroe added a commit that referenced this pull request May 15, 2025

fix(nuxt): support reactive keys in useLazyAsyncData (#32092)

ff9271c

github-actions bot mentioned this pull request May 15, 2025

v3.17.4 #32106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nuxt): support reactive keys in `useLazyAsyncData` #32092

fix(nuxt): support reactive keys in `useLazyAsyncData` #32092

Uh oh!

danielroe commented May 13, 2025

Uh oh!

bolt-new-by-stackblitz bot commented May 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 13, 2025

Uh oh!

Copilot AI May 13, 2025

Uh oh!

coderabbitai bot commented May 13, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 13, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented May 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

	if (typeof args[0] !== 'string' && typeof args[0] !== 'object' && !(typeof args[0] === 'function' && typeof args[1] === 'function')) { args.unshift(autoKey) }
	if (args[0] != null && typeof args[0] !== 'string' && typeof args[0] !== 'object' && !(typeof args[0] === 'function' && typeof args[1] === 'function')) { args.unshift(autoKey) }

-  if (typeof args[0] !== 'string' && typeof args[0] !== 'object' && !(typeof args[0] === 'function' && typeof args[1] === 'function')) { args.unshift(autoKey) }
+  const isStringKey = typeof args[0] === 'string'
+  const isReactiveKey = typeof args[0] === 'object'
+  const isHandlerOnlySignature = typeof args[0] === 'function' && typeof args[1] === 'function'
+  if (!isStringKey && !isReactiveKey && !isHandlerOnlySignature) {
+    args.unshift(autoKey)
+  }

Uh oh!

fix(nuxt): support reactive keys in useLazyAsyncData #32092

fix(nuxt): support reactive keys in useLazyAsyncData #32092

Uh oh!

Conversation

danielroe commented May 13, 2025

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented May 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI May 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 13, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #32092 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

fix(nuxt): support reactive keys in `useLazyAsyncData` #32092

fix(nuxt): support reactive keys in `useLazyAsyncData` #32092

coderabbitai bot commented May 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented May 13, 2025 •

edited

Loading

codspeed-hq bot commented May 13, 2025 •

edited

Loading