perf(nuxt): use Intl.Collator instead of localeCompare #32167

moshetanzer · 2025-05-20T12:30:55Z

🔗 Linked issue

📚 Description

bolt-new-by-stackblitz · 2025-05-20T12:30:59Z

Run & review this pull request in StackBlitz Codeflow.

Copilot

Pull Request Overview

Implements a more performant, consistent sort by replacing localeCompare with a reusable Intl.Collator comparator.

Instantiate an Intl.Collator for en-US
Use its compare method to sort scannedFiles by relativePath

Comments suppressed due to low confidence (1)

packages/nuxt/src/pages/utils.ts:58

Add a unit test to verify that sorting with Intl.Collator yields the same order as the previous localeCompare implementation across various Unicode cases.

scannedFiles.sort((a, b) => enUSComparator(a.relativePath, b.relativePath))

packages/nuxt/src/pages/utils.ts

coderabbitai · 2025-05-20T12:32:54Z

Walkthrough

A new Intl.Collator instance for the 'en-US' locale, named enUSComparator, was introduced at the module level. The sorting of scanned files by their relative path in the resolvePagesRoutes function was updated to use the enUSComparator.compare method instead of calling localeCompare with the 'en-US' locale string on each comparison. Additionally, a guard clause was added at the start of the generateRoutesFromFiles function to immediately return an empty array if the input files array is empty, preventing further processing. There were no changes to the declarations or signatures of any exported or public entities.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e68412 and ca3f4eb.

📒 Files selected for processing (1)

packages/nuxt/src/pages/utils.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/nuxt/src/pages/utils.ts

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch optimize-page-utils
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-05-20T12:38:03Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32167

nuxt

npm i https://pkg.pr.new/nuxt@32167

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32167

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32167

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32167

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32167

commit: ca3f4eb

codspeed-hq · 2025-05-20T12:57:24Z

CodSpeed Performance Report

Merging #32167 will not alter performance

_{Comparing moshetanzer:optimize-page-utils (ca3f4eb) with main (94c86b9)}

Summary

✅ 10 untouched benchmarks

packages/nuxt/src/pages/utils.ts

perf(nuxt): use Intl.Collator instead of localeCompare

d0364ab

Copilot AI review requested due to automatic review settings May 20, 2025 12:30

moshetanzer requested a review from danielroe as a code owner May 20, 2025 12:30

github-actions bot added 3.x performance labels May 20, 2025

Copilot AI reviewed May 20, 2025

View reviewed changes

packages/nuxt/src/pages/utils.ts Outdated Show resolved Hide resolved

fix: copilot suggestion

3e68412

chore: add early return, filter out group otkens before mapping

fac7318

danielroe reviewed May 20, 2025

View reviewed changes

packages/nuxt/src/pages/utils.ts Outdated Show resolved Hide resolved

chore: use 1x fewer iteration

ca3f4eb

danielroe approved these changes May 20, 2025

View reviewed changes

danielroe merged commit be9cec3 into nuxt:main May 20, 2025
46 checks passed

github-actions bot mentioned this pull request May 20, 2025

v4.0.0 #27716

Draft

danielroe pushed a commit that referenced this pull request May 20, 2025

perf(nuxt): use Intl.Collator instead of localeCompare (#32167)

4cccbc9

github-actions bot mentioned this pull request May 20, 2025

v3.17.4 #32106

Merged

moshetanzer deleted the optimize-page-utils branch May 20, 2025 19:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(nuxt): use Intl.Collator instead of localeCompare #32167

perf(nuxt): use Intl.Collator instead of localeCompare #32167

Uh oh!

moshetanzer commented May 20, 2025

Uh oh!

bolt-new-by-stackblitz bot commented May 20, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coderabbitai bot commented May 20, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 20, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented May 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

perf(nuxt): use Intl.Collator instead of localeCompare #32167

perf(nuxt): use Intl.Collator instead of localeCompare #32167

Uh oh!

Conversation

moshetanzer commented May 20, 2025

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented May 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

coderabbitai bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #32167 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

coderabbitai bot commented May 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented May 20, 2025 •

edited

Loading

codspeed-hq bot commented May 20, 2025 •

edited

Loading