Skip to content

fix(vite): use arrow functions in dynamic imports #32285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

fix(vite): use arrow functions in dynamic imports #32285

merged 1 commit into from
Jun 3, 2025

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #32175

📚 Description

due to an upstream rollup bug in how arrow functions vs inline functions are treated (it fails to collect dependencies correctly), it strips default exports from dynamically imported modules

by emitting arrow functions instead we bypass this, but we can revisit when it a fix is merged upstream

@Copilot Copilot AI review requested due to automatic review settings June 3, 2025 15:45
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copilot
Copilot AI reviewed Jun 3, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a Rollup bug related to dynamic imports by enabling arrow functions in the generated code configuration.

  • Enables the arrowFunctions flag to help preserve default exports in dynamic imports.
  • Adds a comment referencing the Rollup issue for future context.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 3, 2025

Walkthrough

A new property, arrowFunctions: true, has been added to the generatedCode configuration object within the Rollup output options in the Vite server build configuration. This adjustment serves as a temporary workaround for a specific issue reported in the Rollup project. No other aspects of the logic, error handling, or control flow have been changed, and there are no modifications to the declarations of exported or public entities.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62afcd5 and 8c36374.

📒 Files selected for processing (1)
  • packages/vite/src/server.ts (1 hunks)
🔇 Additional comments (1)
packages/vite/src/server.ts (1)

104-105: Approve the temporary Rollup workaround.

Adding arrowFunctions: true under generatedCode with a reference to the Rollup issue correctly implements the intended fix. Remember to remove this flag once upstream issue #5975 is resolved.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 3, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32285

nuxt

npm i https://pkg.pr.new/nuxt@32285

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32285

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32285

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32285

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32285

commit: 8c36374

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 3, 2025

CodSpeed Performance Report

Merging #32285 will not alter performance

Comparing fix/named-rollup (8c36374) with main (62afcd5)

Summary

✅ 10 untouched benchmarks

@danielroe danielroe merged commit b40a7d5 into main Jun 3, 2025
47 checks passed
@danielroe danielroe deleted the fix/named-rollup branch June 3, 2025 16:20
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
Draft
danielroe added a commit that referenced this pull request Jun 3, 2025
@danielroe
fix(vite): use arrow functions in dynamic imports (#32285)
05507b4
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

named exports of components are incorrectly exposed
1 participant
@danielroe
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy