fix(nuxt): respect `inheritAttrs: false` in `createClientOnly` fn #32323

DamianGlowala · 2025-06-06T15:58:53Z

🔗 Linked issue

resolves #32317

📚 Description

Makes client component respect inheritAttrs: false in linked case.

bolt-new-by-stackblitz · 2025-06-06T15:58:57Z

Run & review this pull request in StackBlitz Codeflow.

Copilot

Pull Request Overview

This PR fixes the behavior of the Nuxt client-only component so that it no longer passes attributes when inheritAttrs is set to false.

Updated the createClientOnly function to conditionally pass attributes.
Added tests to validate that attributes are omitted when inheritAttrs is false.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
test/nuxt/client-only.test.ts	New test added to verify inheritAttrs behavior
packages/nuxt/src/app/components/client-only.ts	Updated createClientOnly to respect inheritAttrs

coderabbitai · 2025-06-06T16:00:35Z

Walkthrough

The changes update the attribute inheritance logic in the createClientOnly function within the Nuxt package. Specifically, the rendering behaviour now checks the inheritAttrs property of the cloned component: if it is explicitly set to false, attributes are not passed; otherwise, attributes are passed as before. Additionally, a new test suite was introduced to verify that components with inheritAttrs: false do not inherit attributes, ensuring the updated logic works as intended. No changes were made to the signatures or declarations of exported or public entities.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f08a548 and 9a63409.

📒 Files selected for processing (2)

packages/nuxt/src/app/components/client-only.ts (1 hunks)
test/nuxt/client-only.test.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: codeql (javascript-typescript)
GitHub Check: codeql (actions)
GitHub Check: build
GitHub Check: code

🔇 Additional comments (2)

packages/nuxt/src/app/components/client-only.ts (1)

126-130: LGTM! Correct implementation of inheritAttrs respect.

The conditional logic properly handles the three-value logic for inheritAttrs (true, false, undefined) and correctly passes undefined when inheritance is disabled, ensuring attributes are not applied to the rendered component.

test/nuxt/client-only.test.ts (1)

82-96: Excellent test coverage for the inheritAttrs: false functionality.

The test correctly validates that components created with createClientOnly respect the inheritAttrs: false setting by confirming that passed attributes (class and id) are not applied to the rendered output. This provides proper regression protection for the fix.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-06-06T16:02:39Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32323

nuxt

npm i https://pkg.pr.new/nuxt@32323

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32323

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32323

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32323

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32323

commit: 9a63409

codspeed-hq · 2025-06-06T16:13:10Z

CodSpeed Performance Report

Merging #32323 will not alter performance

_{Comparing fix/inherit-attrs-client-component-vanilla-ts (9a63409) with main (f08a548)}

Summary

✅ 10 untouched benchmarks

danielroe

nice! ❤️

…2323)

DamianGlowala added 2 commits June 6, 2025 17:02

fix(nuxt): respect inheritAttrs in createClientOnly function

f956e42

add test case

9a63409

Copilot AI review requested due to automatic review settings June 6, 2025 15:58

DamianGlowala requested a review from danielroe as a code owner June 6, 2025 15:58

Copilot AI reviewed Jun 6, 2025

View reviewed changes

github-actions bot added 3.x bug labels Jun 6, 2025

danielroe approved these changes Jun 6, 2025

View reviewed changes

danielroe merged commit 156a80b into main Jun 6, 2025
47 checks passed

danielroe deleted the fix/inherit-attrs-client-component-vanilla-ts branch June 6, 2025 16:19

github-actions bot mentioned this pull request Jun 6, 2025

v4.0.0 #27716

Draft

danielroe pushed a commit that referenced this pull request Jul 1, 2025

fix(nuxt): respect inheritAttrs: false in createClientOnly fn (#3…

5422e54

…2323)

github-actions bot mentioned this pull request Jul 1, 2025

v3.17.6 #32346

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nuxt): respect `inheritAttrs: false` in `createClientOnly` fn #32323

fix(nuxt): respect `inheritAttrs: false` in `createClientOnly` fn #32323

Uh oh!

DamianGlowala commented Jun 6, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Jun 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai bot commented Jun 6, 2025

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jun 6, 2025

Uh oh!

codspeed-hq bot commented Jun 6, 2025

Uh oh!

danielroe left a comment

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

fix(nuxt): respect inheritAttrs: false in createClientOnly fn #32323

fix(nuxt): respect inheritAttrs: false in createClientOnly fn #32323

Uh oh!

Conversation

DamianGlowala commented Jun 6, 2025

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Jun 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

coderabbitai bot commented Jun 6, 2025

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jun 6, 2025

Uh oh!

codspeed-hq bot commented Jun 6, 2025

CodSpeed Performance Report

Merging #32323 will not alter performance

Summary

Uh oh!

danielroe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

fix(nuxt): respect `inheritAttrs: false` in `createClientOnly` fn #32323

fix(nuxt): respect `inheritAttrs: false` in `createClientOnly` fn #32323

CodeRabbit Configuration File (`.coderabbit.yaml`)