Skip to content

chore: rename deprecated vitest workspace to projects #32388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

OrbisK
Copy link
Collaborator

@OrbisK OrbisK commented Jun 13, 2025

📚 Description

This PR fixes the deprecation warning from vitest

> nuxt-framework@ test:prepare /home/runner/work/nuxt/nuxt
> jiti ./test/prepare.ts
 DEPRECATED  The `workspace` option is deprecated and will be removed in the next major. To hide this warning, rename `workspace` option to `projects`.

@Copilot Copilot AI review requested due to automatic review settings June 13, 2025 13:51
@OrbisK OrbisK requested a review from danielroe as a code owner June 13, 2025 13:51
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the deprecated "workspace" option to "projects" in the vitest configuration to resolve the deprecation warning issued by vitest.

  • Renamed "workspace" to "projects" in vitest.config.ts
  • Ensured the configuration aligns with the latest vitest guidelines

Copy link

coderabbitai bot commented Jun 13, 2025

Walkthrough

The Vitest configuration file was updated by changing the key used to define multiple test projects from "workspace" to "projects". The array containing the project configurations itself was not altered; only the key name within the exported configuration object was modified. No changes were made to any exported or public entities.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b56bb9 and c7b687e.

📒 Files selected for processing (1)
  • vitest.config.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: danielroe
PR: nuxt/nuxt#32121
File: vitest.config.ts:13-14
Timestamp: 2025-05-15T15:05:46.645Z
Learning: In Vitest configuration, the correct property name for defining multiple test projects is `workspace` (singular), not `workspaces` (plural).
Learnt from: danielroe
PR: nuxt/nuxt#32121
File: vitest.config.ts:13-14
Timestamp: 2025-05-15T15:05:46.645Z
Learning: In Vitest configuration, the correct property name for defining multiple test projects is `workspace` (singular), not `workspaces` (plural).
vitest.config.ts (2)
Learnt from: danielroe
PR: nuxt/nuxt#32121
File: vitest.config.ts:13-14
Timestamp: 2025-05-15T15:05:46.645Z
Learning: In Vitest configuration, the correct property name for defining multiple test projects is `workspace` (singular), not `workspaces` (plural).
Learnt from: danielroe
PR: nuxt/nuxt#32121
File: vitest.config.ts:13-14
Timestamp: 2025-05-15T15:05:46.645Z
Learning: In Vitest configuration, the correct property name for defining multiple test projects is `workspace` (singular), not `workspaces` (plural).
🔇 Additional comments (2)
vitest.config.ts (2)

14-14: Updated to projects – aligns with Vitest v1 API
The rename cleanly removes the deprecation warning and matches the current schema.


14-14:

✅ Verification successful

Check repo for obsolete workspace usages
To avoid unexpected config splits, make sure no other vitest.config.* files still declare the old key.


🏁 Script executed:

#!/bin/bash
# Find any remaining `workspace:` keys in Vitest configs
rg --glob '*vitest.config.*' -n $'workspace:'

Length of output: 44


No obsolete workspace keys found in Vitest configs
A search across all vitest.config.* files returned no occurrences of the old workspace: key, so the rename has been applied consistently. No further action is needed.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch chore/vitetest-deprecation
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Jun 13, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32388

nuxt

npm i https://pkg.pr.new/nuxt@32388

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32388

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32388

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32388

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32388

commit: c7b687e

Copy link

codspeed-hq bot commented Jun 13, 2025

CodSpeed Performance Report

Merging #32388 will not alter performance

Comparing OrbisK:chore/vitetest-deprecation (c7b687e) with main (4b56bb9)

Summary

✅ 10 untouched benchmarks

@danielroe danielroe merged commit 9c7398b into nuxt:main Jun 13, 2025
47 checks passed
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy