-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
fix(nuxt): ensure newKey asyncData runs when oldKey asyncData is still running #32466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7b76c0a
fix(asyncData): ensure newKey asyncData runs when oldKey asyncData is…
OrbisK f6944bb
chore: remove logging
OrbisK cd16295
test: add e2e test to prevent regression
OrbisK 25e5a6a
test: use single root element
OrbisK 3175bc0
test: add runtime tests
OrbisK 1066a24
revert: test: use single root element
OrbisK cf6a159
revert: test: add e2e test to prevent regression
OrbisK 766b3df
fix: use updated test condition
danielroe 7c741c4
test: run test in all projects
danielroe f8354c2
Merge remote-tracking branch 'origin/main' into fix/async-data-while-…
danielroe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add unit tests (e.g., using Vitest) for the new key-change logic in
useAsyncData
to cover cases whereisRunning
is true, as required by our core functionality testing guidelines.Copilot uses AI. Check for mistakes.