-
-
Notifications
You must be signed in to change notification settings - Fork 954
Migrate middleware to their own Go modules #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f27fcb
to
a4517f4
Compare
Similar to our work with the migration to separate modules for the `pkg/runtime` and `pkg/types` packages, we can do the same for the middleware. This allows us to iterate over these quicker than the underlying code generator and gives us the opportunity to introduce breaking changes more easily if appropriate. These won't be removed until the next major version, but we can mark them as deprecated to nudge folks to move away from them.
To nudge people to move along to the new versions in their own repos.
a4517f4
to
1ab5294
Compare
chrisgacsal
added a commit
to openclarity/vmclarity
that referenced
this pull request
Oct 24, 2023
Followup on this change oapi-codegen/oapi-codegen#1257.
github-merge-queue bot
pushed a commit
to openclarity/vmclarity
that referenced
this pull request
Oct 24, 2023
….1 (#847) * chore(deps): bump github.com/deepmap/oapi-codegen from 1.15.0 to 1.16.1 Bumps [github.com/deepmap/oapi-codegen](https://github.com/deepmap/oapi-codegen) from 1.15.0 to 1.16.1. - [Release notes](https://github.com/deepmap/oapi-codegen/releases) - [Commits](oapi-codegen/oapi-codegen@v1.15.0...v1.16.1) --- updated-dependencies: - dependency-name: github.com/deepmap/oapi-codegen dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: generate API code * fix: import echo middleware Followup on this change oapi-codegen/oapi-codegen#1257. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
kodiakhq bot
referenced
this pull request
in cloudquery/filetypes
Feb 1, 2024
…432) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/deepmap/oapi-codegen](https://togithub.com/deepmap/oapi-codegen) | indirect | minor | `v1.15.0` -> `v1.16.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>deepmap/oapi-codegen (github.com/deepmap/oapi-codegen)</summary> ### [`v1.16.2`](https://togithub.com/deepmap/oapi-codegen/releases/tag/v1.16.2): : Further improve documentation notices [Compare Source](https://togithub.com/deepmap/oapi-codegen/compare/v1.16.1...v1.16.2) #### What's Changed - Improve deprecation notices by [@​jamietanna](https://togithub.com/jamietanna) in [https://github.com/deepmap/oapi-codegen/pull/1337](https://togithub.com/deepmap/oapi-codegen/pull/1337) **Full Changelog**: oapi-codegen/oapi-codegen@v1.16.1...v1.16.2 ### [`v1.16.1`](https://togithub.com/deepmap/oapi-codegen/releases/tag/v1.16.1): : Ensure deprecation comments appear correctly [Compare Source](https://togithub.com/deepmap/oapi-codegen/compare/v1.16.0...v1.16.1) #### What's Changed - Fix: Ensure deprecations are parsed correctly by [@​jamietanna](https://togithub.com/jamietanna) in [https://github.com/deepmap/oapi-codegen/pull/1335](https://togithub.com/deepmap/oapi-codegen/pull/1335) **Full Changelog**: oapi-codegen/oapi-codegen@v1.16.0...v1.16.1 ### [`v1.16.0`](https://togithub.com/deepmap/oapi-codegen/releases/tag/v1.16.0): : Reduce runtime dependencies [Compare Source](https://togithub.com/deepmap/oapi-codegen/compare/v1.15.0...v1.16.0) As part of the final preparation towards the [v2 release](https://togithub.com/deepmap/oapi-codegen/discussions/1309), this release finalises the use of the new multi-repo packages, and deprecates all internal packages ahead of next week's release removing them. #### Key callouts - Migrate middleware to their own Go modules by [@​jamietanna](https://togithub.com/jamietanna) in [https://github.com/deepmap/oapi-codegen/pull/1257](https://togithub.com/deepmap/oapi-codegen/pull/1257) - Replace + deprecate `testutil` by [@​jamietanna](https://togithub.com/jamietanna) in [https://github.com/deepmap/oapi-codegen/pull/1314](https://togithub.com/deepmap/oapi-codegen/pull/1314) **Full Changelog**: oapi-codegen/oapi-codegen@v1.15.0...v1.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE2My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
kodiakhq bot
referenced
this pull request
in cloudquery/codegen
Feb 1, 2024
…142) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/deepmap/oapi-codegen](https://togithub.com/deepmap/oapi-codegen) | indirect | minor | `v1.15.0` -> `v1.16.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>deepmap/oapi-codegen (github.com/deepmap/oapi-codegen)</summary> ### [`v1.16.2`](https://togithub.com/deepmap/oapi-codegen/releases/tag/v1.16.2): : Further improve documentation notices [Compare Source](https://togithub.com/deepmap/oapi-codegen/compare/v1.16.1...v1.16.2) #### What's Changed - Improve deprecation notices by [@​jamietanna](https://togithub.com/jamietanna) in [https://github.com/deepmap/oapi-codegen/pull/1337](https://togithub.com/deepmap/oapi-codegen/pull/1337) **Full Changelog**: oapi-codegen/oapi-codegen@v1.16.1...v1.16.2 ### [`v1.16.1`](https://togithub.com/deepmap/oapi-codegen/releases/tag/v1.16.1): : Ensure deprecation comments appear correctly [Compare Source](https://togithub.com/deepmap/oapi-codegen/compare/v1.16.0...v1.16.1) #### What's Changed - Fix: Ensure deprecations are parsed correctly by [@​jamietanna](https://togithub.com/jamietanna) in [https://github.com/deepmap/oapi-codegen/pull/1335](https://togithub.com/deepmap/oapi-codegen/pull/1335) **Full Changelog**: oapi-codegen/oapi-codegen@v1.16.0...v1.16.1 ### [`v1.16.0`](https://togithub.com/deepmap/oapi-codegen/releases/tag/v1.16.0): : Reduce runtime dependencies [Compare Source](https://togithub.com/deepmap/oapi-codegen/compare/v1.15.0...v1.16.0) As part of the final preparation towards the [v2 release](https://togithub.com/deepmap/oapi-codegen/discussions/1309), this release finalises the use of the new multi-repo packages, and deprecates all internal packages ahead of next week's release removing them. #### Key callouts - Migrate middleware to their own Go modules by [@​jamietanna](https://togithub.com/jamietanna) in [https://github.com/deepmap/oapi-codegen/pull/1257](https://togithub.com/deepmap/oapi-codegen/pull/1257) - Replace + deprecate `testutil` by [@​jamietanna](https://togithub.com/jamietanna) in [https://github.com/deepmap/oapi-codegen/pull/1314](https://togithub.com/deepmap/oapi-codegen/pull/1314) **Full Changelog**: oapi-codegen/oapi-codegen@v1.15.0...v1.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE2My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
ramizpolic
pushed a commit
to openclarity/openclarity
that referenced
this pull request
Aug 12, 2024
….1 (vmclarity#847) * chore(deps): bump github.com/deepmap/oapi-codegen from 1.15.0 to 1.16.1 Bumps [github.com/deepmap/oapi-codegen](https://github.com/deepmap/oapi-codegen) from 1.15.0 to 1.16.1. - [Release notes](https://github.com/deepmap/oapi-codegen/releases) - [Commits](oapi-codegen/oapi-codegen@v1.15.0...v1.16.1) --- updated-dependencies: - dependency-name: github.com/deepmap/oapi-codegen dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: generate API code * fix: import echo middleware Followup on this change oapi-codegen/oapi-codegen#1257. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
ramizpolic
pushed a commit
to openclarity/openclarity
that referenced
this pull request
Aug 12, 2024
….1 (#847) * chore(deps): bump github.com/deepmap/oapi-codegen from 1.15.0 to 1.16.1 Bumps [github.com/deepmap/oapi-codegen](https://github.com/deepmap/oapi-codegen) from 1.15.0 to 1.16.1. - [Release notes](https://github.com/deepmap/oapi-codegen/releases) - [Commits](oapi-codegen/oapi-codegen@v1.15.0...v1.16.1) --- updated-dependencies: - dependency-name: github.com/deepmap/oapi-codegen dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: generate API code * fix: import echo middleware Followup on this change oapi-codegen/oapi-codegen#1257. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
ramizpolic
pushed a commit
to openclarity/openclarity
that referenced
this pull request
Aug 12, 2024
….1 (vmclarity#847) * chore(deps): bump github.com/deepmap/oapi-codegen from 1.15.0 to 1.16.1 Bumps [github.com/deepmap/oapi-codegen](https://github.com/deepmap/oapi-codegen) from 1.15.0 to 1.16.1. - [Release notes](https://github.com/deepmap/oapi-codegen/releases) - [Commits](oapi-codegen/oapi-codegen@v1.15.0...v1.16.1) --- updated-dependencies: - dependency-name: github.com/deepmap/oapi-codegen dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: generate API code * fix: import echo middleware Followup on this change oapi-codegen/oapi-codegen#1257. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase merge 👍