Skip to content

Prefactor: Build changes for #1475 #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Prefactor: Build changes for #1475 #1482

merged 6 commits into from
Mar 4, 2024

Conversation

jamietanna
Copy link
Member

  • build: remove invalid make target
  • build: add make lint to make help
  • build: remove unnecessary output
  • build: create a Makefile per module
  • build: Add tidy-ci make target
  • build: explicitly set GOTOOLCHAIN

As part of future changes to introduce the `net/http`-only server, we'll
introduce the reliance on Go 1.22-only code.

The way that we currently lint/build/etc the project doesn't make this
easy to do so, so we should instead refactor our build steps to make
this easier.

This is the best option I can see right now, but will be happy to tweak
it if we can find an alternative.
I'd not realised that we were - still - using this separate setup just
in GitHub Actions.

To make this cleaner, as well as fit into our new structure for managing
multi-module `Makefile`s, we can create a new `make` task for CI.
@jamietanna jamietanna added the chore Any maintenance tasks that are regular, not as important to call out in the changelog label Mar 4, 2024
Both to fix issues with Go 1.21's detection of `go env GOVERSION`, as
well as generally making it extra explicit that we don't want to
auto-upgrade.
@jamietanna jamietanna merged commit 74e9346 into master Mar 4, 2024
@jamietanna jamietanna deleted the chore/prefactor branch May 5, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Any maintenance tasks that are regular, not as important to call out in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy