feat(std-http): accept Mux interface instead of *http.ServeMux
#1720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Aug 9, 2024
ccoVeille
approved these changes
Aug 10, 2024
jamietanna
reviewed
Aug 16, 2024
| @@ -3,21 +3,27 @@ func Handler(si ServerInterface) http.Handler { | |||
| return HandlerWithOptions(si, StdHTTPServerOptions{}) | |||
| } | |||
|
|
|||
| // ServeMux is an abstraction of http.ServeMux. | |||
| type ServeMux interface { | |||
There was a problem hiding this comment.
Does this need to be exported? Probably no big deal it is, but thought I'd ask
There was a problem hiding this comment.
It’s good since you use it in the method’s arguments.
jamietanna
reviewed
Aug 16, 2024
Mux interface instead of *http.ServeMux
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described on Issue #1718, I'm implementing receiving Mux as interface instead of *http.ServeMux.
Following the open-closed principle, it will allow the library to be more customizable for the developers.