Skip to content

fix(import-mapping): don't produce unused variable when one mapping #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix(import-mapping): don't produce unused variable when one mapping #1781

merged 1 commit into from
Sep 28, 2024

Conversation

ottaviohartman
Copy link
Contributor

Fixes #1779 .

I chose to inline the .Dir() function since it is simplest.

@ottaviohartman ottaviohartman requested a review from a team as a code owner September 24, 2024 21:25
@jamietanna
Copy link
Member

Looks good! We'll possibly also want to make sure this has a test case covering it - I can add it when I'm back (as I need to see where'd make sense)

@jamietanna jamietanna changed the title fix: pathPrefix issue fix(import-mapping): don't produce unused variable when one mapping Sep 28, 2024
@jamietanna jamietanna enabled auto-merge (squash) September 28, 2024 10:26
@jamietanna jamietanna added the bug Something isn't working label Sep 28, 2024
jamietanna
jamietanna approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jamietanna jamietanna merged commit 7ce53fa into oapi-codegen:main Sep 28, 2024
18 checks passed
@jamietanna jamietanna mentioned this pull request Sep 28, 2024
Merged
@jamietanna jamietanna mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamietanna jamietanna jamietanna approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pathPrefix not used when using self import mapping
2 participants
@ottaviohartman @jamietanna
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy