Add reqval.fill_id_token with technicals OIDC fields into id_token
#660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new RequestValidator `fill_id_token` has been introduced to replace `get_id_token`. It aims to have the bare minimum amount of fields to complete a full OIDC id_token support. `get_id_token` is still valid but optional, and if it is implemented, `fill_id_token` will not be called. The current `fill_id_token` came with full support of `aud`, `iat`, `nonce`, `at_hash` and `c_hash`. More could come in the future e.g. `auth_time`, ...
2 tasks
skion
reviewed
Mar 5, 2019
|
The only concern is when we need support claim extension if will be easy to do in configurable way. Any ideia on that? |
Rename hash_id_token into id_token_hash
|
Hi @skion, your initial comments have been solved. I have also added the missing unittests to increase coverage. Could you have another look? Hi @wiliamsouza, yes, claims is the next feature that it should be improved. I don't see any roadblocks to this.? |
reqval.fill_id_token with technicals OIDC fields into id_tokenreqval.fill_id_token with technicals OIDC fields into id_token
This function should always have a good client_id and redirect_uri, because it is called after validate_token_request()
Merged
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of:
Deprecate the 3.0.0
get_id_tokenin favor offinalize_id_tokenfill_id_tokenget_id_tokenis still working if implemented. It gives the user the choice to either implement the full JWT build, or take the advantage of oauthlib and completing the id_token & signing it.Work is still to be done regarding
max_time/auth_time,claims, and maybe few others.