Skip to content

Add case-insensitive headers to oauth1 BaseEndpoint #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2019
Merged

Add case-insensitive headers to oauth1 BaseEndpoint #669

merged 1 commit into from
May 6, 2019

Conversation

ngoue
Copy link
Contributor

@ngoue ngoue commented Apr 24, 2019

Add support for case-insensitive headers to the oauth1 BaseEndpoint._create_request to ensure headers are recognized in all endpoints.

@ngoue
Copy link
Contributor Author

ngoue commented Apr 24, 2019

I'm working with AWS API Gateway and right now I'm having to alter the Content-Type header manually in order to get my SignatureOnlyEndpoint to validate correctly.

Let me know if I'm using this wrong, but I figured we should be allowing case-insensitive headers here as well.

@JonathanHuot JonathanHuot added this to the 3.1.0 milestone Apr 26, 2019
@JonathanHuot
Copy link
Member

LGTM

@JonathanHuot
Copy link
Member

Hi @ngoue, could you please add a commit to retrigger the Travis-CI build ? I open an issue on their supprot because it didn't trigger any builds for your PR. Now they say it is fixed, but it requires another commit/push.

@JonathanHuot
Copy link
Member

Hi @ngoue, could you please retry again to force-push ? I'm liaising with Travis-CI support team to understand why this is again triggering issues.

@JonathanHuot
Copy link
Member

Hi @ngoue, it seems Travis CI team is not able to remove you from the "Abuse" list because you have no TravisCI account attached to your github account. I will run the build on locally on my side and if the tests are passing I'll force the merge of this PR.
Stay with me :-)

@JonathanHuot JonathanHuot merged commit c376e27 into oauthlib:master May 6, 2019
@JonathanHuot
Copy link
Member

Build has been run locally due to the TravisCI bug and all tests were passing.

@ngoue
Copy link
Contributor Author

ngoue commented May 6, 2019

Hahaha interesting... I guess I'll go make a Travis CI account and connect them. Sorry to cause so much trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy