Skip to content

CI: Only attempt upload for upstream #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Aug 26, 2023

Add an extra conditional because there's no point attempting upload from forks because they'll fail as they don't have the credentials.

Before

image

Notice: Attempting to perform trusted publishing exchange to retrieve a temporary short-lived API token for authentication against https://upload.pypi.org/legacy/ due to token username with no supplied password field

https://github.com/hugovk/oauthlib/actions/runs/5984901609

Also remove the double curly brackets, they prevent the if statement from being evaluated properly.

After

image

https://github.com/hugovk/oauthlib/actions/runs/5985055507

@JonathanHuot JonathanHuot requested a review from auvipy August 28, 2023 17:00
@auvipy auvipy merged commit af7c6aa into oauthlib:master Aug 29, 2023
@hugovk hugovk deleted the deploy-upstream-only branch August 29, 2023 06:05
@JonathanHuot JonathanHuot added this to the 3.3.0 milestone May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy