Handle expires_at with best effort basis #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a best‑effort handling of the token attribute "expires_at" by updating the conversion logic across token parsing and client methods, and adds a multi‑case test for various "expires_at" types.
- Updated tests to cover multiple input types for "expires_at" and removed an invalid case test.
- Changed the computation of expires_at in parameters and adjusted the client’s parsing logic accordingly.
- Added a dependency on pytest‑subtests to support sub‑test execution.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/oauth2/rfc6749/clients/test_base.py | Updated tests for various "expires_at" types and removed an invalid test case. |
| requirements-test.txt | Added pytest‑subtests as a dependency. |
| oauthlib/oauth2/rfc6749/parameters.py | Changed expires_at computation to use round(time.time()). |
| oauthlib/oauth2/rfc6749/clients/base.py | Updated token attribute parsing with layered conversion for expires_at. |
Comments suppressed due to low confidence (1)
tests/oauth2/rfc6749/clients/test_base.py:303
- Consider retaining or reintroducing tests for invalid 'expires_at' values to ensure robust error handling for malformed inputs.
def test_parse_token_response_invalid_expires_at(self):
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
auvipy
approved these changes
May 18, 2025
Added similar behaviors to all interfaces where expires_at is parsed, this will facilitate the implementations. Note this is breaking change for those which are expecting the "default" `expires_at` (as in, not provided) to be a float. This will now default to a int.
|
I fixed few edge cases and added more unit tests to cover all scenarios. |
|
I reviewed but forgot to merge 🗡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #899