Skip to content

Fix 3.3.0 regression of expires_in #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2025
Merged

Fix 3.3.0 regression of expires_in #907

merged 6 commits into from
Jun 20, 2025

Conversation

JonathanHuot
Copy link
Member

Support #906 discussion.

@@ -500,9 +500,9 @@ def parse_expires(params):
# Attempt to convert to int
expires_in = int(params.get('expires_in'))
except ValueError:
raise ValueError("expires_int must be an int")
raise ValueError("expires_in must be an int")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting typo it was!

@JonathanHuot JonathanHuot marked this pull request as ready for review June 19, 2025 15:50
@JonathanHuot JonathanHuot changed the title Add unit test sample based on 3.3.0 regression of expires_in Fix 3.3.0 regression of expires_in Jun 19, 2025
@JonathanHuot JonathanHuot added Bug OAuth2-Client This impact the client part of OAuth2. labels Jun 19, 2025
@JonathanHuot JonathanHuot added this to the 3.3.1 milestone Jun 19, 2025
Having two workflows are usually required when different events are used. Calling from one workflow another workflow of the same repository is not efficient and clear.
@JonathanHuot
Copy link
Member Author

Release has been deployed with success.
However, the publish job still have two issues:

  • Duplicate push/pull_request triggers twice the publish jobs
  • Errr no tags has been set, but the publish job has been triggered! this is not expected

@JonathanHuot JonathanHuot merged commit eb185bb into master Jun 20, 2025
27 of 28 checks passed
@JonathanHuot JonathanHuot deleted the release-3.3.1 branch June 20, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug OAuth2-Client This impact the client part of OAuth2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy