PEP 621: Migrate from setup.{py, cfg} to pyproject.toml #914

cclauss · 2025-06-30T14:35:18Z

https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

https://peps.python.org/pep-0621

Migrate setup.py to setup.cfg using setuptools-py2cfg plus manual modifications. Then migrate setup.cfg to pyproject.toml using ini2toml to do the file conversion and running pyproject-fmt and then validate-pyproject to validate the results.

uvx --with=oauthlib setuptools-py2cfg > setup.cfg
uvx 'ini2toml[full]' setup.cfg -o pyproject.toml
git add pyproject.toml
uvx pyproject-fmt pyproject.toml
uvx 'validate-pyproject[all]' pyproject.toml
migrate ruff.toml to pyproject.toml
ruff check
migrate requirements*.txt to pyproject.toml  # Tox still needs them :-(
git rm setup.py
git rm setup.cfg
git rm ruff.toml
edit GitHub Actions

Codespell and mypy settings (in GitHub Action) and tox.ini could also be migrated.

cclauss · 2025-07-01T04:28:13Z

@webknjaz, your review would be greatly appreciated, esp. on the PyPI release bits.

.github/workflows/lint_python.yml

.github/workflows/python-build.yml

pyproject.toml

ruff.toml

Copilot

Pull Request Overview

This PR migrates project configuration from setup.py and setup.cfg to a PEP 621–compliant pyproject.toml and updates CI workflows accordingly.

Remove legacy setup.py and setup.cfg
Introduce pyproject.toml with build-system and project metadata
Adjust GitHub Actions workflows to install extras and reference matrix variables

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
setup.py	Legacy setup script removed
setup.cfg	Legacy configuration removed
pyproject.toml	New PEP 621 configuration for build-system and project metadata
.github/workflows/python-build.yml	Updated COVERALLS_FLAG_NAME reference
.github/workflows/lint_python.yml	Changed editable install to include selected extras

Comments suppressed due to low confidence (2)

.github/workflows/python-build.yml:29

The workflow references matrix.python but the strategy matrix key is named python-version. It should use ${{ matrix.python-version }} to match the defined matrix.

          COVERALLS_FLAG_NAME: ${{ matrix.python }}

webknjaz · 2025-07-11T15:49:39Z

pyproject.toml

+]
+optional-dependencies.rsa = [ "cryptography>=3" ]
+optional-dependencies.signals = [ "blinker>=1.4" ]
+optional-dependencies.signedtoken = [ "cryptography>=3", "pyjwt>=2,<3" ]


I think you can use recursive refs like

Suggested change

optional-dependencies.signedtoken = [ "cryptography>=3", "pyjwt>=2,<3" ]

optional-dependencies.signedtoken = [ ". [rsa]", "PyJWT >=2, <3" ]

(but please test to make sure)

Let's revisit that in a separate PR. I find it to be unintuitive.

It belongs in this PR as the previous implementation used a common source for these, and now it's disconnected. I believe that such a PR shouldn't include a behavior change.

Your reformulation says to me we are going to install . (this whole project) and then rsa (which is an unintuitive alias for cryptography), and then PyJWT. Putting the . in there means that we are disabling any use of --group-only.

Agree - recursive deps seems more prone to error and harder to read & understand. Let's keep cryptography in both groups.

setup.cfg

.github/workflows/lint_python.yml

pyproject.toml

webknjaz · 2025-07-11T15:56:40Z

.github/workflows/lint_python.yml

@@ -15,8 +15,7 @@ jobs:
      - run: pip install codespell mypy pytest ruff safety


Wonder why these aren't in the dependency groups. They could probably be moved into a linters group.

Additionally, that pip install at the top doesn't need to install setuptools or wheel at all. Replace it with a pip install 'pip >= 25.1' # for dependency group support

I would move codespell, ruff, and safety into pre-commit or pipx run them.
I see little value in moving them to a separate file from the file in which they are run.

Safety should probably be dropped.

But since you're already moving some of the deps to groups, move the rest.

Let's keep that task until those are shif-lefted into a pre-commit, or if integrated into tox; or also wait until #916 is progressing.

cclauss had a problem deploying to pypi June 30, 2025 14:36 — with GitHub Actions Failure

cclauss force-pushed the pyproject.toml branch from 04dc852 to 23043de Compare June 30, 2025 14:38

cclauss had a problem deploying to pypi June 30, 2025 14:39 — with GitHub Actions Failure

cclauss force-pushed the pyproject.toml branch from 23043de to e5f6622 Compare June 30, 2025 14:45

cclauss had a problem deploying to pypi June 30, 2025 14:46 — with GitHub Actions Failure

cclauss force-pushed the pyproject.toml branch 2 times, most recently from cc81b4a to 8745a65 Compare June 30, 2025 14:51

cclauss had a problem deploying to pypi June 30, 2025 14:53 — with GitHub Actions Failure

cclauss force-pushed the pyproject.toml branch from 8745a65 to 5e3ba91 Compare July 1, 2025 03:37

cclauss had a problem deploying to pypi July 1, 2025 03:38 — with GitHub Actions Failure

cclauss force-pushed the pyproject.toml branch from 5e3ba91 to 40e374c Compare July 1, 2025 04:10

cclauss temporarily deployed to pypi July 1, 2025 04:13 — with GitHub Actions Inactive

cclauss force-pushed the pyproject.toml branch from 40e374c to fcfc0be Compare July 1, 2025 04:17

cclauss temporarily deployed to pypi July 1, 2025 04:18 — with GitHub Actions Inactive

cclauss force-pushed the pyproject.toml branch from fcfc0be to 473cb25 Compare July 1, 2025 04:26

cclauss temporarily deployed to pypi July 1, 2025 04:27 — with GitHub Actions Inactive

cclauss force-pushed the pyproject.toml branch from 473cb25 to 8d096dd Compare July 1, 2025 04:30

cclauss had a problem deploying to pypi July 1, 2025 04:30 — with GitHub Actions Failure

cclauss force-pushed the pyproject.toml branch from 8d096dd to bb26cb2 Compare July 1, 2025 04:34

cclauss temporarily deployed to pypi July 1, 2025 04:35 — with GitHub Actions Inactive

cclauss force-pushed the pyproject.toml branch from bb26cb2 to f1b5320 Compare July 1, 2025 04:39

cclauss temporarily deployed to pypi July 1, 2025 04:40 — with GitHub Actions Inactive

PEP 621: Migrate from setup.{py, cfg} to pyproject.toml

697475e

cclauss force-pushed the pyproject.toml branch from f1b5320 to 697475e Compare July 1, 2025 04:41

cclauss temporarily deployed to pypi July 1, 2025 04:42 — with GitHub Actions Inactive

auvipy requested review from Copilot and auvipy July 1, 2025 06:25

This comment was marked as outdated.

Sign in to view

webknjaz reviewed Jul 1, 2025

View reviewed changes

cclauss requested a review from JonathanHuot July 11, 2025 05:18

This comment was marked as outdated.

Sign in to view

auvipy had a problem deploying to pypi July 11, 2025 07:11 — with GitHub Actions Failure

auvipy requested review from Copilot and removed request for webknjaz July 11, 2025 07:15

auvipy had a problem deploying to pypi July 11, 2025 07:15 — with GitHub Actions Failure

auvipy requested a review from webknjaz July 11, 2025 07:15

This comment was marked as outdated.

Sign in to view

remove dependencies and fix find.exclude

242583e

cclauss force-pushed the pyproject.toml branch from 15e8c15 to 242583e Compare July 11, 2025 07:16

cclauss had a problem deploying to pypi July 11, 2025 07:17 — with GitHub Actions Failure

pip install --editable .[signedtoken,test]

56525ae

cclauss had a problem deploying to pypi July 11, 2025 07:24 — with GitHub Actions Failure

pip install --editable .[signals,signedtoken,test]

0f68217

cclauss had a problem deploying to pypi July 11, 2025 07:29 — with GitHub Actions Failure

cclauss requested a review from Copilot July 11, 2025 07:30

Copilot AI reviewed Jul 11, 2025

View reviewed changes

webknjaz reviewed Jul 11, 2025

View reviewed changes

setup.cfg Outdated Show resolved Hide resolved

webknjaz reviewed Jul 11, 2025

View reviewed changes

.github/workflows/lint_python.yml Outdated Show resolved Hide resolved

webknjaz reviewed Jul 11, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

webknjaz reviewed Jul 11, 2025

View reviewed changes

cclauss had a problem deploying to pypi July 11, 2025 16:25 — with GitHub Actions Failure

Still more ongoing tweeks

d56d548

cclauss force-pushed the pyproject.toml branch from 582ad3b to d56d548 Compare July 11, 2025 16:28

cclauss had a problem deploying to pypi July 11, 2025 16:29 — with GitHub Actions Failure

Create .isort.cfg

97948e6

cclauss had a problem deploying to pypi July 11, 2025 20:34 — with GitHub Actions Failure

cclauss added 2 commits July 12, 2025 18:07

pypi-publish: if: ... github.ref_type = 'tag'

c045249

github.ref_type == 'tag'

ce2f6c3

	optional-dependencies.signedtoken = [ "cryptography>=3", "pyjwt>=2,<3" ]
	optional-dependencies.signedtoken = [ ". [rsa]", "PyJWT >=2, <3" ]

		@@ -15,8 +15,7 @@ jobs:
		- run: pip install codespell mypy pytest ruff safety

Uh oh!

PEP 621: Migrate from setup.{py, cfg} to pyproject.toml #914

Are you sure you want to change the base?

PEP 621: Migrate from setup.{py, cfg} to pyproject.toml #914

Conversation

cclauss commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cclauss commented Jul 1, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

webknjaz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

cclauss Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

webknjaz Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cclauss Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

JonathanHuot Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webknjaz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

cclauss Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webknjaz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

JonathanHuot Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

cclauss commented Jun 30, 2025 •

edited

Loading

webknjaz Jul 11, 2025 •

edited

Loading

cclauss Jul 11, 2025 •

edited

Loading