Improve github action to publish package #915
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated build from publish job. Migrated from twine to python build Fix #913
webknjaz
reviewed
Jul 10, 2025
webknjaz
reviewed
Jul 10, 2025
| - name: Install prereq | ||
| run: pip install tox | ||
| - name: Run python tests | ||
| run: tox -e ${{ matrix.toxenv }} | ||
| pypi-publish: | ||
| build: |
There was a problem hiding this comment.
A possible future improvement could be building before running tests and then testing the same dists. But that's a separate possibility out of the scope of publishing.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
webknjaz
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer attempt to publish package for each commit due to a broken if statement.
Added build/upload artifact job.
Removed build from publish job.
Migrated from twine to python build
Fix #913 based on https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/