Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build light weight PyRuntime without llvm or onnx-mlir #3044

Merged
merged 15 commits into from
Jan 29, 2025
+786 −61
Merged

Build light weight PyRuntime without llvm or onnx-mlir #3044

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4ab6256
pass test
chentong319 Jan 15, 2025
49034b5
package
chentong319 Jan 15, 2025
45b1d9d
clean makefile
chentong319 Jan 15, 2025
0ee214f
Merge remote-tracking branch 'upstream/main' into pyruntime-lit
chentong319 Jan 15, 2025
beff2e3
document
chentong319 Jan 15, 2025
28584dd
fix MLIR.cmake
chentong319 Jan 15, 2025
a92ccc2
fix script
chentong319 Jan 15, 2025
2037d8d
Merge remote-tracking branch 'upstream/main' into pyruntime-lit
chentong319 Jan 16, 2025
8ecd7ff
fix
chentong319 Jan 21, 2025
79ab54f
Merge remote-tracking branch 'upstream/main' into pyruntime-lit
chentong319 Jan 21, 2025
0bd61d2
Merge remote-tracking branch 'upstream/main' into pyruntime-lit
chentong319 Jan 27, 2025
0694678
add comments
chentong319 Jan 27, 2025
0d049a5
Merge remote-tracking branch 'upstream/main' into pyruntime-lit
chentong319 Jan 27, 2025
8c8a17f
LIGHT
chentong319 Jan 29, 2025
8ff28b1
Merge remote-tracking branch 'upstream/main' into pyruntime-lit
chentong319 Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean makefile 
Signed-off-by: Chen Tong <chentong@us.ibm.com>
  • Loading branch information
@chentong319
chentong319 committed Jan 15, 2025
commit 45b1d9d3f2ece96650a5506f8b4dbab99465738e
5 changes: 0 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ option(ONNX_MLIR_ENABLE_WERROR "Enable warnings as errors." OFF)
option(ONNX_MLIR_SUPPRESS_THIRD_PARTY_WARNINGS "Suppress warning in third_party code." ON)
option(ONNX_MLIR_ENABLE_JAVA "Set to ON for building the Java runtime, tools, and tests" ON)
option(ONNX_MLIR_ENABLE_PYRUNTIME_LIT "Set to ON for building Python driver of running the compiled model without llvm-project." OFF)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the name should be explained: if off, then no pyruntime is build? Or its build anyway, but when on, then it's only the pyruntime? Or when off, pyruntime is build one way, but when off, its build another way?

Maybe the name could be a bit more explicit, depending on what the answer is from the question above.

minor question: _LIT is it for "_LIGHT"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this option is off, the pyruntime is built with onnx-mlir and llvm-project, as it was previously.
When this option is on, only the pyruntime is built without llvm-project.

Yes, LIT for LIGHT.

#unset(ONNX_MLIR_ENABLE_PYRUNTIME_LIT CACHE)

set(CMAKE_CXX_STANDARD 17)

Expand Down Expand Up @@ -213,10 +212,6 @@ if (ONNX_MLIR_SUPPRESS_THIRD_PARTY_WARNINGS)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DSUPPRESS_THIRD_PARTY_WARNINGS")
endif()

if (ONNX_MLIR_ENABLE_STABLEHLO)
add_compile_definitions(ONNX_MLIR_ENABLE_STABLEHLO)
endif()

if (ONNX_MLIR_ENABLE_PYRUNTIME_LIT)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this (and above): there are some dir that added on both path. Is it that the order of them is important?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the src is added on both path. I do not think the order of add_subdirectory matters. Just to keep the original add_subdirectory together.

add_subdirectory(src)
else()
Expand Down
1 change: 0 additions & 1 deletion MLIR.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: Apache-2.0

message(STATUS "ONNX_MLIR_ENABLE_PYRUNTIME_LIT: ${ONNX_MLIR_ENABLE_PYRUNTIE_LIT}")
if (ONNX_MLIR_ENABLE_PYRUNTIME_LIT)
function(llvm_update_compile_flags name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a one liner comment on why this function is defined here.

endfunction()
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy