[Fix] Robust mapping from image path to seg map path #3091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation Update repo information and URLs in README. ## Modification ## BC-breaking (Optional) ## Use cases (Optional) --------- Co-authored-by: CSH <40987381+csatsurnh@users.noreply.github.com>
|
|
xiexinch
approved these changes
Jun 16, 2023
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
## Motivation Suppose an image is named `jpg.jpg` and its corresponding segmap is named `jpg.png`. The original implementation will try to read segmap from `png.png` and causes FileNotfoundError ## Modification Only replace the suffix, instead of full string search and replacement. ## BC-breaking (Optional) Probably no. ## Use cases (Optional) ## Checklist 1. Pre-commit or other linting tools are used to fix the potential lint issues. 2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness. 3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D. 4. The documentation has been modified accordingly, like docstring or example tutorials. --------- Co-authored-by: 谢昕辰 <xiexinch@outlook.com> Co-authored-by: CSH <40987381+csatsurnh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Suppose an image is named
jpg.jpgand its corresponding segmap is namedjpg.png.The original implementation will try to read segmap from
png.pngand causes FileNotfoundErrorModification
Only replace the suffix, instead of full string search and replacement.
BC-breaking (Optional)
Probably no.
Use cases (Optional)
Checklist