Skip to content

Update deprecated attributes #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

weslenteche
Copy link
Contributor

Hi, I noticed that some deprecated attributes were missing from updating.

@weslenteche weslenteche requested a review from a team October 19, 2023 23:52
@welcome
Copy link

welcome bot commented Oct 19, 2023

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #207 (ad7c082) into main (6ec34b4) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head ad7c082 differs from pull request most recent head 52525cb. Consider uploading reports for the commit 52525cb to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #207      +/-   ##
============================================
+ Coverage     33.11%   33.12%   +0.01%     
  Complexity      852      852              
============================================
  Files            76       76              
  Lines          3249     3248       -1     
============================================
  Hits           1076     1076              
+ Misses         2173     2172       -1     
Flag Coverage Δ
7.4 46.34% <ø> (ø)
8.0 33.05% <0.00%> (+0.01%) ⬆️
8.1 33.08% <0.00%> (+0.01%) ⬆️
8.2 33.07% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tion/Laravel/src/Watchers/ClientRequestWatcher.php 0.00% <ø> (ø)
...Instrumentation/Psr18/src/Psr18Instrumentation.php 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec34b4...52525cb. Read the comment docs.

@brettmc
Copy link
Contributor

brettmc commented Oct 20, 2023

Thanks, @weslenteche !

@brettmc brettmc merged commit f58bbf8 into open-telemetry:main Oct 20, 2023
@weslenteche weslenteche deleted the update-semconv-tracesattributes branch October 20, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy