Skip to content

[Laravel] Allow Laravel 12 #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2025
Merged

[Laravel] Allow Laravel 12 #333

merged 1 commit into from
Mar 16, 2025

Conversation

IonBazan
Copy link
Contributor

Allows Laravel 12 to be installed with open-telemetry/opentelemetry-auto-laravel

@IonBazan IonBazan requested a review from a team as a code owner February 24, 2025 03:27
@welcome Welcome
Copy link

welcome bot commented Feb 24, 2025

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 24, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: IonBazan / name: Ion Bazan (c381611)

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (65de07e) to head (c381611).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #333   +/-   ##
=========================================
  Coverage     80.42%   80.42%           
  Complexity     1502     1502           
=========================================
  Files           128      128           
  Lines          6176     6176           
=========================================
  Hits           4967     4967           
  Misses         1209     1209
Flag Coverage Δ
Aws 85.55% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Instrumentation/CakePHP 20.27% <ø> (ø)
Instrumentation/CodeIgniter 73.77% <ø> (ø)
Instrumentation/Curl 90.42% <ø> (ø)
Instrumentation/ExtAmqp 89.26% <ø> (ø)
Instrumentation/ExtRdKafka 86.23% <ø> (ø)
Instrumentation/Guzzle 69.51% <ø> (ø)
Instrumentation/HttpAsyncClient 78.31% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 62.68% <ø> (ø)
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/PDO 90.15% <ø> (ø)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr15 89.41% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 77.77% <ø> (ø)
Instrumentation/Psr3 59.49% <ø> (ø)
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.30% <ø> (ø)
Instrumentation/Symfony 84.93% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65de07e...c381611. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisLightfootWild
Copy link
Contributor

I propose we wait until #315 lands to ensure that the tests all pass under PHP 8.4.

@ChrisLightfootWild
Copy link
Contributor

Hey @IonBazan 👋

Please could you merge main so the 8.4 pipeline could run for this?

@bobstrecansky bobstrecansky mentioned this pull request Feb 27, 2025
Closed
ChrisLightfootWild
ChrisLightfootWild approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IonBazan 👍

I've not had time to actually test Laravel 12 myself yet but, given the tests all pass, I would be happy to add my ✅

Have you managed to run this in a L12 test app?

@IonBazan
Copy link
Contributor Author

IonBazan commented Mar 6, 2025

Hey sorry, unfortunately I don't have any L12 app ready yet. I believe there weren't any major changes that would break current instrumentation though.

@kylemilloy kylemilloy mentioned this pull request Mar 13, 2025
Closed
@IonBazan
Copy link
Contributor Author

Hi @ChrisLightfootWild, can we please get this merged? I believe there are multiple mirror PRs created in subtrees as well.

@brettmc brettmc merged commit 5c9ab13 into open-telemetry:main Mar 16, 2025
120 of 124 checks passed
@kylemilloy kylemilloy mentioned this pull request Mar 19, 2025
Closed
@brettmc
Copy link
Contributor

brettmc commented Mar 19, 2025

released 1.1.1 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLightfootWild ChrisLightfootWild ChrisLightfootWild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IonBazan @ChrisLightfootWild @brettmc
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy