Skip to content

fix getUndistortRectangles() to ignore corners #27374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion modules/calib3d/src/calibration_base.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1527,7 +1527,7 @@ void cv::getUndistortRectangles(InputArray _cameraMatrix, InputArray _distCoeffs
{
const int N = 9;
int x, y, k;
Mat _pts(1, 4*(N-1), CV_64FC2);
Mat _pts(1, 4*(N-2), CV_64FC2);
Point2d* pts = _pts.ptr<Point2d>();

// generate a grid of points across the image to estimate the distortion deformation
Expand All @@ -1543,6 +1543,12 @@ void cv::getUndistortRectangles(InputArray _cameraMatrix, InputArray _distCoeffs
// have no influence on the two deformation rectangles that are calculated below
continue;
}
if ((x == 0 || x == N - 1) && (y == 0 || y == N - 1))
{
// skip corners, because undistortPoints is likely to fail and return the same
// value
continue;
}
pts[k++] = Point2d(x * stepX, y * stepY);
}
}
Expand All @@ -1561,6 +1567,10 @@ void cv::getUndistortRectangles(InputArray _cameraMatrix, InputArray _distCoeffs
{
continue;
}
if ((x == 0 || x == N - 1) && (y == 0 || y == N - 1))
{
continue;
}

Point2d p = pts[k++];
oX0 = MIN(oX0, p.x);
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy