Skip to content

Made some GDAL specific tests optional #27504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Jul 2, 2025

Fixes

[ RUN      ] Imgcodecs_gdal.read_fits
ERROR 4: `/build/precommit_linux64/4.x/opencv_extra/testdata/highgui/../cv/gdal/fits_test.fit' not recognized as a supported file format.
/build/precommit_linux64/4.x/opencv/modules/imgcodecs/test/test_gdal.cpp:15: Failure
Value of: img.empty()
  Actual: true
Expected: false
[  FAILED  ] Imgcodecs_gdal.read_fits (0 ms)

.fit format test made optional because GDAL may be built without CFITSIO library support

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.12.0 milestone Jul 2, 2025
@asmorkalov asmorkalov self-assigned this Jul 2, 2025
@asmorkalov asmorkalov merged commit 6b55ae0 into opencv:4.x Jul 2, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy