Drop use of importlib_metadata
#2054
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
mattwthompson
commented
May 22, 2025
| @@ -13,6 +13,7 @@ | |||
| import logging | |||
| import os | |||
| import pathlib | |||
| from importlib.metadata import entry_points | |||
There was a problem hiding this comment.
This is arguably a style change but I will defend it on a few points
- I question whether or not it makes sense to have standard library imports guarded
- The code paths are pretty hot with respect to each module, i.e. almost all functionality that requires importing from these files will end up calling one of these code paths
- It's a pretty quick import, not counting anything else that's already brought in by other imports
$ time python -c "" 16:11:52 ☁ stdlib-entry-points ☂ ✭
python -c "" 0.01s user 0.01s system 51% cpu 0.049 total
(bespokefit-test) [openff-toolkit]
$ time python -c "from importlib.metadata import entry_points" 16:12:22 ☁ stdlib-entry-points ☂ ✭
python -c "from importlib.metadata import entry_points" 0.05s user 0.02s system 67% cpu 0.105 total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib-metadatais a third-party package which backports features ofimportlib.metadata(which is in the standard library) to older Python versions. We were using it as a bridge while it was "provisional" but that ship has long passed.This change is likely 3.10+ based on my reading of the docs, but I haven't pinned it down completely: https://docs.python.org/3/library/importlib.metadata.html
This was not declared as a dependency in test environments - it probably should have been - but is a requirement in packaging. This change would allow that to be dropped from the conda recipe.