(fix) Improvements to workspace system styling (supports O3-3246) #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
denniskigen
previously approved these changes
Jun 20, 2024
There was a problem hiding this comment.
I welcome the simplification! Thanks, @brandones. I'm curious to see how this works on an actual tablet device. @donaldkibet is it possible to get Josh to test this out?
| @@ -81,6 +81,6 @@ html[dir='rtl'] { | |||
| border-right: 0.25rem solid var(--brand-01); | |||
| border-left: unset; | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
It appears the indentation is off for this entire :global(.cds--side-nav) block.
There was a problem hiding this comment.
Bummer we still don't have scss auto-formatting I guess?
Meant to comment instead of explicitly approve.
|
Build is failing due to form-lib needing to be updated with the latest OpenmrsDatePicker update. |
|
Size Change: -514 kB (-4.43%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
|
The bottom nav should have a top border on tablet https://zeroheight.com/23a080e38/p/948cf1-siderail-and-bottom-nav:
Also, note to self (for me) to fix the positioning of the placeholder text for the vitals and biometrics fields on tablet. |
Whoops! I'll need to fix that in core. Separate PR.
Did you pull the latest? I did a screw-up |
denniskigen
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
LGTM apart from the top border on the bottom (which I imagine is a change to make in Core). Thanks, @brandones! Also, I think the viewport height means it should work very well on tablet (based on my responsive mode testing).
|
Looks great on iPad mini @brandones @gracepotma trim.EA6DFC46-716E-455A-B447-1D9DF346C95A.MOV |
|
I've tested on my 8" android tablet and it looks like this fixes other long-standing responsiveness issues such as the action buttons in the drug order form not being clickable. @donaldkibet, could you and your team verify this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REQUIRES openmrs/openmrs-esm-core#1046
Requirements
Summary
Updates use of the workspace system to reflect the changes in openmrs/openmrs-esm-core#1046
Screenshots
See openmrs/openmrs-esm-core#1046
Related Issue
Other