Skip to content

Better Missing Track Section Error Message #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2025
Merged

Better Missing Track Section Error Message #1063

merged 1 commit into from
Mar 30, 2025

Conversation

SteelFill
Copy link
Contributor

In response to this request, this changes the error message displayed when a route needs a track shape missing from tsection.dat.

  • Error message now declares which shape index couldn't be found (only the first missing shape can be detected, as the program will stop before additional track sections are processed) which should make it vastly easier to determine what's missing.
  • The error no longer mentions any specific track systems, as it is misleading to imply this error is related to any specific track system.
  • Probable cause is now stated to be the wrong version of the standard tsection.dat or the route requiring a non-standard tsection.dat, as this is what will actually produce the error.

@SteelFill SteelFill added the enhancement New feature or request label Mar 23, 2025
twpol pushed a commit that referenced this pull request Mar 23, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 9 pull requests
d516007 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 1a01818: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 24, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 9 pull requests
dd7c6f0 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 1a01818: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 24, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 9 pull requests
70ddc14 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 2b45594: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 24, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 10 pull requests
0eae0cc 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 2b45594: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 26, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 10 pull requests
d84420d 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 556ad1d: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 26, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 10 pull requests
12f283f 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 28, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 11 pull requests
f7ad19a 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at eb49b25: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
@rwf-rr
Copy link
Contributor

rwf-rr commented Mar 28, 2025

Looks fine to me, and it addresses the concern raised in the referenced thread.

twpol pushed a commit that referenced this pull request Mar 28, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 11 pull requests
ada1bb5 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
cesarBLG
cesarBLG approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@cesarBLG cesarBLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new error message is more clear, thanks for the change

twpol pushed a commit that referenced this pull request Mar 29, 2025
@openrails-bot
Automatic merge of T1.5.1-1678-gf88b8b9b1 and 11 pull requests
b404306 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 29, 2025
@openrails-bot
Automatic merge of T1.5.1-1678-gf88b8b9b1 and 12 pull requests
d8d87d6 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1067 at 777efaf: Traction and dynamic brake retardation
twpol pushed a commit that referenced this pull request Mar 29, 2025
@openrails-bot
Automatic merge of T1.5.1-1678-gf88b8b9b1 and 13 pull requests
88b3e3e 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1067 at 777efaf: Traction and dynamic brake retardation
twpol pushed a commit that referenced this pull request Mar 29, 2025
@openrails-bot
Automatic merge of T1.5.1-1678-gf88b8b9b1 and 11 pull requests
fb65914 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1057 at cf3caa0: Switchable brake system
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
@SteelFill SteelFill merged commit 0cd8cb8 into openrails:master Mar 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarBLG cesarBLG cesarBLG approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteelFill @rwf-rr @cesarBLG
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy