Skip to content

refact(ups): Add support for async save call using rest UPS. #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2022
Merged

refact(ups): Add support for async save call using rest UPS. #350

merged 2 commits into from
Dec 20, 2022

Conversation

yasirfolio3
Copy link
Contributor

Summary

  • This adds support for asynchronous Save using rest UPS by setting async boolean value inside config.yaml.
userProfileService:
      default: "rest"
      services:
        rest: 
          async: true

Tests

  • Added new unit tests.
  • All previous tests should pass.

@204Constie
Copy link

:shipit:

@msohailhussain msohailhussain mentioned this pull request Dec 19, 2022
Closed
msohailhussain
msohailhussain approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit a4cbf60 into master Dec 20, 2022
@msohailhussain msohailhussain deleted the yasir/async_rest_ups branch December 20, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasirfolio3 @204Constie @msohailhussain
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy