[FSSDK-8971] feat: add FetchQualifiedSegments to Decide #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasirfolio3
suggested changes
Mar 2, 2023
| @@ -12,7 +12,7 @@ require ( | |||
| github.com/golang-jwt/jwt/v4 v4.5.0 | |||
| github.com/google/uuid v1.3.0 | |||
| github.com/lestrrat-go/jwx v0.9.0 | |||
| github.com/optimizely/go-sdk v1.8.3 | |||
| github.com/optimizely/go-sdk v1.8.4-0.20230216074708-27b2772ccf33 | |||
There was a problem hiding this comment.
This should be done using go mod tidy and go mod clean to automatically update go.sum and remove irrelevant indirect dependencies which were needed by go-sdk 1.8.3.
| DecideOptions []string `json:"decideOptions"` | ||
| ForcedDecisions []ForcedDecision `json:"forcedDecisions,omitempty"` | ||
| FetchSegments bool `json:"fetchSegments"` | ||
| FetchSegmentsOptions []segment.OptimizelySegmentOption `json:"fetchSegmentsOptions,omitempty"` |
There was a problem hiding this comment.
Can we confirm that if user sends a wrong value here then this will not break? maybe have 3 unit tests:
- pass a single incorrect value in array
- pass a mixture of correct and incorrect values
- pass a empty array
jaeopt
requested changes
Mar 3, 2023
yasirfolio3
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
LGTM, just needs an update to openapi.yaml as @jaeopt suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket
FSSDK-8971