[FSSDK-9705] feat: add OpenTelemetry tracing #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikechu-optimizely
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Mostly just questions 👇 but otherwise LGTM...though probably should also get @jaeopt 's review.
jaeopt
requested changes
Oct 11, 2023
jaeopt
reviewed
Oct 11, 2023
jaeopt
reviewed
Oct 12, 2023
jaeopt
requested changes
Oct 17, 2023
ah sorry, config changes are fall behind for distributed tracing. btw I am still thinking what the config should be. |
13d341c to
51cc0f9
Compare
pulak-opti
added a commit
that referenced
this pull request
Nov 2, 2023
* add a basic tracing pipeline * add tracing config * update tracing config * use context * update handler with middleware * support both http & grpc protocal * refactor config * add unit test * update unit test * refactor code * make tracing disabled by default * add config doc * fix typo * collect more attributes * add common http attributes * collect http status code attribute * collect sdk key attribute * support distributed tracing * add unit test for trace id generator * update unit test * fix typo * fix typo in config file * update config.yaml * make trace_id configurable for distributed tracing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket