Skip to content

refact: Impression event correction #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

refact: Impression event correction #234

merged 1 commit into from
Nov 3, 2021

Conversation

ozayr-zaviar
Copy link
Contributor

Summary

  • Impression Param implementation refactoring

Test plan

  • Should pass all unit tests and FSC tests.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.257% when pulling 0ce7497 on uzair/impression-refactor into bc3bb03 on mnoman/forcedDecision.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.257% when pulling 0ce7497 on uzair/impression-refactor into bc3bb03 on mnoman/forcedDecision.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.257% when pulling 0ce7497 on uzair/impression-refactor into bc3bb03 on mnoman/forcedDecision.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.257% when pulling 0ce7497 on uzair/impression-refactor into bc3bb03 on mnoman/forcedDecision.

@ozayr-zaviar ozayr-zaviar removed their assignment Oct 29, 2021
@msohailhussain msohailhussain marked this pull request as ready for review November 3, 2021 19:11
@msohailhussain msohailhussain requested a review from a team as a code owner November 3, 2021 19:11
@msohailhussain msohailhussain merged commit 7566d55 into mnoman/forcedDecision Nov 3, 2021
@msohailhussain msohailhussain deleted the uzair/impression-refactor branch November 3, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤖 16 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozayr-zaviar @coveralls @msohailhussain @optimizely-codereview-bot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy