Skip to content

Add proper return type to user context json serialize #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add proper return type to OptimizelyUserContext::jsonSerialize
The following indirect deprecation notice is popping up when calling OptimizelyUserContext::jsonSerialize in php 8+:

1x: Method "JsonSerializable::jsonSerialize()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Optimizely\OptimizelyUserContext" now to avoid errors or add an explicit @return annotation to suppress this message.
  • Loading branch information
samybasset committed Jun 14, 2022
commit a7d4eaa05749965d5982028bfe58686206b62f2e
3 changes: 3 additions & 0 deletions src/Optimizely/OptimizelyUserContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ public function getOptimizely()
return $this->optimizelyClient;
}

/**
* @return mixed
*/
#[\ReturnTypeWillChange]
public function jsonSerialize()
{
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy