Skip to content

[FSSDK-9022] Dev Containers and bug bash #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Jun 26, 2023
Merged

[FSSDK-9022] Dev Containers and bug bash #269

merged 44 commits into from
Jun 26, 2023

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Jun 9, 2023

Summary

  • Updating php-sdk to be compatible with php version 8.2

Test plan

  • unit tests passing
    • FSC tests passing
    • bug bash passing

Issues

https://jira.sso.episerver.net/browse/FSSDK-9022
https://jira.sso.episerver.net/browse/FSSDK-9073
https://jira.sso.episerver.net/browse/FSSDK-9071
https://jira.sso.episerver.net/browse/FSSDK-9072

mikechu-optimizely and others added 30 commits May 30, 2023 17:12
@mikechu-optimizely
Add bug bash autoloader
38f9db1
@mikechu-optimizely
Initial version of decide tests
91aa14c
@mikechu-optimizely
Fix autoloads; DRY print to console
0051573
@mikechu-optimizely
Refactor and clean using
c31820a
@mikechu-optimizely
Refactor; Fix array outputs
833e6bb
@mikechu-optimizely
Better output in linux env
785389f
@mikechu-optimizely
Add notification on decide test
47fcac7
@mikechu-optimizely
Output log to ensure logx impression sent
e7c18c7
@mikechu-optimizely
Verify error is logged for invalid flag
610279a
@mikechu-optimizely
Add devcontainer config
2d1b5a1
@mikechu-optimizely
Install dependencies in devcontainer
af21844
@mikechu-optimizely
Update decide instructions
1567ac2
@mikechu-optimizely
Add postCreateCommand shell postCreateCommand
12a9b70
@mikechu-optimizely
Fix path on postCreateCommand
e59ed4b
@mikechu-optimizely
Finish devcontainer config
a15ce19
@mikechu-optimizely
Refine decide.php
3a13a5e
@mikechu-optimizely
Renamed files & their refs
82faf92
@mikechu-optimizely
Instruction update
e05a86f
@mikechu-optimizely
Add DecideAll skeleton
00a2522
@mikechu-optimizely
Initial DecideAll test
cc16486
@mikechu-optimizely
Finish DecideAll test; Decide fixes
8453c4a
@mikechu-optimizely
DecideForKeys skeleton
8774b37
@mikechu-optimizely
Add decide for keys; update other decide classes
626c7d4
@mikechu-optimizely
Comment DecideForKeys test calls
96bb0c0
@mikechu-optimizely
Track event test class skeleton
fcb1ee4
@mikechu-optimizely
Update attributes in decide tests
aabd432
@mikechu-optimizely
Add track event tests
5378d93
@mikechu-optimizely
DRY $onTrackEvent and use in negative test
165c566
@mikechu-optimizely
Event Key instead of "name"
bb0eeaf
@mikechu-optimizely
Forced Decision skeleton
b29dead
@Mat001 Mat001 requested a review from a team as a code owner June 9, 2023 17:11
@coveralls
Copy link

coveralls commented Jun 9, 2023 •
edited
Loading

Coverage Status

coverage: 97.333%. remained the same when pulling 3810ed3 on mike/bug-bash-php8 into e197aa4 on master.

mikechu-optimizely
mikechu-optimizely approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely changed the title Mike/bug bash php8 [FSSDK-9022] Dev Containers and bug bash Jun 26, 2023
@mikechu-optimizely
Copy link
Contributor

@Mat001 Feel free to squash and merge when ready.

@Mat001 Mat001 merged commit 04f5c20 into master Jun 26, 2023
@Mat001 Mat001 deleted the mike/bug-bash-php8 branch June 26, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@Mat001 Mat001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mat001 @coveralls @mikechu-optimizely
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy