Initial SD Card Support #636
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
FIXME: This should have been two commits. Signed-off-by: Daniel Maslowski <info@orangecms.org> Signed-off-by: Ben Werthmann <ben.werthmann@gmail.com>
Signed-off-by: Ben Werthmann <ben.werthmann@gmail.com>
Signed-off-by: Ben Werthmann <ben.werthmann@gmail.com>
Signed-off-by: Ben Werthmann <ben.werthmann@gmail.com>
b368d31 to
41d42a7
Compare
Codecov Report
@@ Coverage Diff @@
## main #636 +/- ##
========================================
- Coverage 2.58% 2.56% -0.02%
========================================
Files 18 19 +1
Lines 581 584 +3
========================================
Hits 15 15
- Misses 566 569 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ben Werthmann <ben.werthmann@gmail.com>
41d42a7 to
6493fb3
Compare
Add critical section. See: * duskmoon314/aw-pac#18 (comment) * oreboot#635 This resolves linker error for critical-section symbols Signed-off-by: Ben Werthmann <ben.werthmann@gmail.com>
rminnich
reviewed
Dec 13, 2022
| @@ -336,6 +344,10 @@ fn xtask_burn_d1_flash_bt0(xfel: &str, env: &Env) { | |||
| let mut command = Command::new(xfel); | |||
| command.current_dir(dist_dir(env, DEFAULT_TARGET)); | |||
| match env.memory { | |||
| Some(Memory::MMC) => { | |||
There was a problem hiding this comment.
I would prefer that writing the SD from oreboot never be implemented ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.