Exposing the native OpenGL ID (issue ##1468) #1736
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdb
requested changes
Apr 6, 2025
| /** | ||
| * Returns the native OpenGL buffer ID for this buffer. | ||
| */ | ||
| uint64_t CLP(BufferContext)::get_native_id() const { |
There was a problem hiding this comment.
Nitpick: Panda style is to put the part starting with get_native_id on a new line. See the other definitions in this file.
| * if this is not a buffer texture. | ||
| */ | ||
| uint64_t BufferContext:: | ||
| get_native_buffer_id() const { |
There was a problem hiding this comment.
There's no need to have a separate get_native_buffer_id (which isn't implemented anyway) for buffers since the get_native_id already returns the buffer id. The distinction only makes sense for textures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
This change exposes the native OpenGL buffer ID via a virtual method in BufferContext. It allows external tools and libraries to interoperate with GPU buffers without copying data between system memory and GPU memory
( Issue #1468 )
Solution description
This PR adds a new method virtual uint64_t get_native_id() const override; to the BufferContext class which returns the contents of the _index member cast to a uint64_t. The method provides direct access to the native OpenGL buffer ID, enabling efficient interoperability with external libraries like CUDA, TensorFlow, and PyTorch. The implementation adheres to Panda3D's existing design patterns and coding style.
Checklist
I have done my best to ensure that…