[DNM until v8.1.3] tikv: add new dynamic configure for flow-control (#18814) #21375
Conversation
Co-authored-by: Grace Cai <qqzczy@126.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the operational flexibility of TiKV by documenting and enabling dynamic configuration for its internal flow control mechanism. The change allows administrators to fine-tune critical flow control parameters on the fly, improving the system's responsiveness to varying workloads and resource conditions without requiring a service restart.
Highlights
- Dynamic Configuration: Introduced five new dynamic configuration parameters for TiKV's flow control mechanism, allowing real-time adjustments without service restarts.
- Flow Control Parameters: Added
storage.flow-control.enable,storage.flow-control.memtables-threshold,storage.flow-control.l0-files-threshold,storage.flow-control.soft-pending-compaction-bytes-limit, andstorage.flow-control.hard-pending-compaction-bytes-limitto the list of dynamically configurable items.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds documentation for new dynamic configuration options related to TiKV's flow control. The changes are in dynamic-config.md. The review focuses on improving the formatting and clarity of the new entries to align with the project's documentation style guide.
| | storage.flow-control.enable | Determines whether to enable the flow control mechanism | | ||
| | storage.flow-control.memtables-threshold | The maximum number of kvDB memtables that trigger flow control | | ||
| | storage.flow-control.l0-files-threshold | The maximum number of kvDB L0 files that trigger flow control | | ||
| | storage.flow-control.soft-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject some write requests | | ||
| | storage.flow-control.hard-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject all write requests | |
There was a problem hiding this comment.
To improve clarity and adhere to the documentation style guide, enclose configuration parameters in backticks1 for proper formatting. The word "mechanism" in the descriptions for soft-pending-compaction-bytes-limit and hard-pending-compaction-bytes-limit is redundant and can be removed for conciseness2.
Style Guide References
| | storage.flow-control.enable | Determines whether to enable the flow control mechanism | | |
| | storage.flow-control.memtables-threshold | The maximum number of kvDB memtables that trigger flow control | | |
| | storage.flow-control.l0-files-threshold | The maximum number of kvDB L0 files that trigger flow control | | |
| | storage.flow-control.soft-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject some write requests | | |
| | storage.flow-control.hard-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject all write requests | | |
| | `storage.flow-control.enable` | Determines whether to enable the flow control | | |
| | `storage.flow-control.memtables-threshold` | The maximum number of kvDB memtables that trigger flow control | | |
| | `storage.flow-control.l0-files-threshold` | The maximum number of kvDB L0 files that trigger flow control | | |
| | `storage.flow-control.soft-pending-compaction-bytes-limit` | The threshold of kvDB pending compaction bytes that triggers flow control to reject some write requests | | |
| | `storage.flow-control.hard-pending-compaction-bytes-limit` | The threshold of kvDB pending compaction bytes that triggers flow control to reject all write requests | |
This is an automated cherry-pick of #18814
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?