fix: Update legend maxheight calculation logic #7483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
reviewed
Jul 24, 2025
| @@ -28,7 +28,7 @@ function findLocaleStrings() { | |||
| var code = fs.readFileSync(file, 'utf-8'); | |||
| var filePartialPath = file.substr(constants.pathToSrc.length); | |||
|
|
|||
| falafel(code, {locations: true}, function(node) { | |||
| falafel(code, { ecmaVersion: 12, locations: true }, function(node) { | |||
There was a problem hiding this comment.
@camdecoster Would you please open a separate PR for these adjustments to falafel arguments? That way we could merge that one quickly and benefit from it in other new PRs.
archmoj
reviewed
Jul 24, 2025
| @@ -188,7 +188,7 @@ function groupDefaults(legendId, layoutIn, layoutOut, fullData) { | |||
|
|
|||
| coerce('xanchor', defaultXAnchor); | |||
| coerce('yanchor', defaultYAnchor); | |||
| coerce('maxheight', isHorizontal ? 0.5 : 1); | |||
| coerce('maxheight'); | |||
There was a problem hiding this comment.
According to the attribute description: "Default value is: 0.5 for horizontal legends; 1 for vertical legends."
So it looks like we should keep it as
coerce('maxheight', isHorizontal ? 0.5 : 1);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the legend maxheight calculation logic to account for the legend being located above/below the plot. Closes #7473.
Changes
maxheightcalculation logicDemo
Testing instructions