Fix #5852: [java] UnnecessaryImport with multiple static imports from same class #5854

Pankraz76 · 2025-06-26T19:27:07Z

#5852: [java] UnnecessaryImport with multiple static imports from same class

Related issues

Fix [java] UnnecessaryImport with multiple static imports from same class #5852

Ready?

Added unit tests for fixed bug/feature
Passing all unit tests
Complete build ./mvnw clean verify passes (checked automatically by github actions)
Added (in-code) documentation (if needed)

Pankraz76 · 2025-06-26T19:28:38Z

added test, could not fix impl. myself. Feel free to take over @oowekyala.

Pankraz76 · 2025-06-27T20:36:15Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+        ]]></code>
+    </test-code>
+    <test-code>
+        <description>#5852: [java] UnnecessaryImport with multiple static imports from same class</description>


…rom same class

Pankraz76

issue ready to investigate by someone in touch with the impl.

pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/UnnecessaryImportRule.java

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

github-actions · 2025-06-27T21:29:24Z

Documentation Preview

Compared to main:
This changeset changes 24 violations,
introduces 1 new violations, 0 new errors and 0 new configuration errors,
removes 697 violations, 0 errors and 0 configuration errors.

Regression Tester Report

(comment created at 2025-06-27 21:29:24+00:00 for ea678bd)

Pankraz76 · 2025-06-28T13:21:57Z

Thanks @iddeepak for the contribution on

RemoveUnusedImports google/google-java-format#1266

You pushed the code so far, the same success here would fix it all, thus the PMD appreciate community your efforts.

The tests are working well, debug is easy.

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

Pankraz76 · 2025-07-10T17:15:22Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+    <!-- Test cases for imports used in module-info.java -->
+<!--    <test-code>-->
+<!--        <description>Import used in module-info requires</description>-->
+<!--        <expected-problems>0</expected-problems>-->
+<!--        <code><![CDATA[-->
+<!--import some.module.ModuleName;-->
+<!--module my.module {-->
+<!--    requires ModuleName;-->
+<!--}-->
+<!--        ]]></code>-->
+<!--    </test-code>-->


Suggested change























imho dont invest on edge case.

adangel · 2025-07-18T07:19:21Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+        ]]></code>
+    </test-code>
+    <test-code>
+        <description>#5852: [java] UnnecessaryImport with multiple static imports from same class - false negative</description>


I think, we should add another test case. Your test case tests the behavior of PMD, if it is not used correctly - it is missing quarkus on the auxclass path - which means, we don't resolve the types and e.g. can't distinguish whether ConfigConfig is a package name or a class (I assume, it is class because of naming conventions).

That's why you need to really reproduce the case correctly:

Create a class ConfigConfig in src/test/java in package net.sourceforge.pmd.lang.java.rule.codestyle.unnecessaryimport

This class should have the nested static class Foo which itself has two public static fields fail and warn.

Maybe you can simplify the code a bit to get rid of unnecessary code lines which are irrelevant for this bug (e.g. no logger is required).

In the end, you code sample should compile - this one doesn't...

Without a proper test, I'm not convinced, that the fix fixes the problem.

adangel · 2025-07-18T07:22:20Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+        <description>Import used in annotation value</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import some.pkg.MyEnum;


This test case should be improved: Please create the related classes/types in src/test/java in package net.sourceforge.pmd.lang.java.rule.codestyle.unnecessaryimport so that we actually use type resolution correctly.

We probably also need to import MyAnnotation.

Alternatively, you might find in the standard java api an enum and an anntoation, you can reuse in the test, so that you don't need to create your own types.

adangel · 2025-07-18T07:23:17Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+        <description>Import used in array annotation value</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import some.pkg.MyEnum;


This test case should be improved: Please create the related classes/types in src/test/java in package net.sourceforge.pmd.lang.java.rule.codestyle.unnecessaryimport so that we actually use type resolution correctly.

adangel · 2025-07-18T07:25:23Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+import java.io.File;
+public class Foo {
+    void test() {
+        list.stream().map((File f) -> f.getName());


this won't compile: list is not known here, so PMD won't know, what the method stream() will return etc...

adangel · 2025-07-18T07:25:44Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+import java.io.File;
+public class Foo {
+    void test() {
+        list.stream().map(File::getName);


this won't compile: list is not known here, so PMD won't know, what the method stream() will return etc...

adangel · 2025-07-18T07:26:53Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+        <description>Import used in switch expression</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import some.pkg.MyEnum;


This test case should be improved: Please create the related classes/types in src/test/java in package net.sourceforge.pmd.lang.java.rule.codestyle.unnecessaryimport so that we actually use type resolution correctly.

adangel · 2025-07-18T07:29:03Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+        <code><![CDATA[
+import some.pkg.MyEnum;
+public class Foo {
+    String test(MyEnum e) {


I'm not sure, if this test case tests what you intended: The type MyEnum is used here as the method parameter, so the import is for this line required.
The cases in the switch expression are unrelated and could be removed.

Maybe you want to test the reverse, e.g. the import static some.pkg.MyEnum.VALUE1 is unnecessary?

adangel · 2025-07-18T07:29:40Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+        <description>Import used in sealed class hierarchy</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import some.pkg.Shape;


This test case should be improved: Please create the related classes/types in src/test/java in package net.sourceforge.pmd.lang.java.rule.codestyle.unnecessaryimport so that we actually use type resolution correctly.

adangel · 2025-07-18T07:31:54Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+import java.time.LocalDate;
+public class Foo {
+    String test(String name) {
+        return """
+            Hello %s!
+            Today is %s
+            """.formatted(name, LocalDate.now());
+    }
 }


Mabye this test case could be simplified? Text block is a string and text block is irrelevant here.

You can achieve the same effect with that:

import java.time.LocalDate; public class Foo { { LocalDate.now(); } }

adangel · 2025-07-18T07:41:29Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+        <description>Import used in record pattern</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import some.pkg.Point;


This test case should be improved: Please create the related classes/types in src/test/java in package net.sourceforge.pmd.lang.java.rule.codestyle.unnecessaryimport so that we actually use type resolution correctly.

adangel · 2025-07-18T07:41:52Z

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml

+        <description>Import used with unnamed pattern variable</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import some.pkg.Point;


This test case should be improved: Please create the related classes/types in src/test/java in package net.sourceforge.pmd.lang.java.rule.codestyle.unnecessaryimport so that we actually use type resolution correctly.

Pankraz76 closed this Jun 26, 2025

Pankraz76 reopened this Jun 26, 2025

adangel changed the title ~~fix #5852: [java] UnnecessaryImport with multiple static imports from same class~~ Fix #5852: [java] UnnecessaryImport with multiple static imports from same class Jun 27, 2025

Pankraz76 commented Jun 27, 2025

View reviewed changes

Pankraz76 force-pushed the fix-UnnecessaryImport branch 2 times, most recently from c0df6dc to f609c55 Compare June 27, 2025 21:10

Fix pmd#5852: [java] UnnecessaryImport with multiple static imports f…

ea678bd

…rom same class

Pankraz76 force-pushed the fix-UnnecessaryImport branch from f609c55 to ea678bd Compare June 27, 2025 21:12

Pankraz76 commented Jun 27, 2025

View reviewed changes

pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/UnnecessaryImportRule.java Show resolved Hide resolved

Pankraz76 marked this pull request as ready for review June 27, 2025 21:13

Pankraz76 commented Jun 27, 2025

View reviewed changes

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml Show resolved Hide resolved

adangel reviewed Jun 29, 2025

View reviewed changes

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml Show resolved Hide resolved

adangel reviewed Jun 29, 2025

View reviewed changes

...va/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UnnecessaryImport.xml Show resolved Hide resolved

Pankraz76 commented Jul 10, 2025

View reviewed changes

adangel reviewed Jul 18, 2025

View reviewed changes

Uh oh!

Fix #5852: [java] UnnecessaryImport with multiple static imports from same class #5854

Are you sure you want to change the base?

Fix #5852: [java] UnnecessaryImport with multiple static imports from same class #5854

Uh oh!

Conversation

Pankraz76 commented Jun 26, 2025 • edited by adangel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#5852: [java] UnnecessaryImport with multiple static imports from same class

Related issues

Ready?

Uh oh!

Pankraz76 commented Jun 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

Pankraz76 commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adangel Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Pankraz76 commented Jun 26, 2025 •

edited by adangel

Loading

Pankraz76 commented Jun 28, 2025 •

edited

Loading

adangel Jul 18, 2025 •

edited

Loading