Skip to content

fix(listing/json): empty filter should print empty array #9688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2025
Merged

fix(listing/json): empty filter should print empty array #9688

merged 4 commits into from
Jun 26, 2025

Conversation

KSXGitHub
Copy link
Contributor

@KSXGitHub KSXGitHub commented Jun 24, 2025 •
edited
Loading

Fixes #9672

@KSXGitHub KSXGitHub requested a review from zkochan as a code owner June 24, 2025 18:29
KSXGitHub
KSXGitHub commented Jun 24, 2025
View reviewed changes
@zkochan
Copy link
Member

zkochan commented Jun 26, 2025

It is weird. I see that the test passes but when I try it locally, nothing is printed.

@KSXGitHub
Copy link
Contributor Author

It is weird. I see that the test passes but when I try it locally, nothing is printed.

If you try it in the pnpm repo then it has packageManager defined. Try it in a repo without packageManager.

@zkochan zkochan merged commit 2893bb9 into main Jun 26, 2025
26 of 29 checks passed
@zkochan zkochan deleted the ls-json-filter-non-existing-should-return-an-empty-array-9672 branch June 26, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pnpm ls --filter non-existing --json should return empty array
2 participants
@KSXGitHub @zkochan
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy